Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support boxplot using maidr-ts #151

Merged
merged 4 commits into from
Apr 8, 2025
Merged

Conversation

dakshpokar
Copy link
Collaborator

Description

This PR adds support for boxplot in pymaidr using maidr-ts engine. Please note that adding support for boxplot using maidr-ts eliminates backwards support using py-maidr with maidr-js engine.

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for boxplot functionality using the maidr-ts engine while eliminating backwards support for the py-maidr/maidr-js engine. Key changes include removing the _extract_axes_data method, modifying the extraction of level data in plot generation, and updating outlier key naming to align with the new engine requirements.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
maidr/core/plot/boxplot.py Removes _extract_axes_data and introduces level extraction logic for boxplots.
maidr/core/enum/maidr_key.py Updates outlier key names for consistency with maidr-ts engine.
example/box/seaborn/example_sns_box.py Sets the engine to "ts" for the seaborn boxplot example.
example/box/matplotlib/example_mpl_box.py Sets the engine to "ts" and updates the boxplot orientation comment.
Comments suppressed due to low confidence (1)

maidr/core/plot/boxplot.py:158

  • The 'levels' value extracted from self.ax might not be iterable as expected when used in the zip with whiskers, caps, medians, and outliers; ensure that extract_level returns an iterable of the same length or adjust the logic to match the expected data structure.
levels = (

Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge once ready.

@dakshpokar dakshpokar merged commit ce42413 into main Apr 8, 2025
9 checks passed
@dakshpokar dakshpokar deleted the feat/support-boxplot branch April 8, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants