Skip to content

fix: eventlistener websocket rpc version and ping #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CryptITAustria merged 1 commit into from
Apr 26, 2025
Merged

fix: eventlistener websocket rpc version and ping #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/utils/resilientEventListener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export function resilientEventListener(args: ResilientEventListenerArgs) {
logCb(`[${new Date().toISOString()}] Subscribing to event listener with topic hash(es): ${topicHashes.join(', ')}`);

const requests = topicHashes.map((topicHash, index) => ({
jsonrpc: "2.0",
id: index + 1,
method: "eth_subscribe",
params: [
Expand All @@ -67,8 +68,9 @@ export function resilientEventListener(args: ResilientEventListenerArgs) {

// sending this backs should return a result of true
const ping = {
jsonrpc: "2.0",
id: requests.length + 1,
method: "net_listening",
method: "net_version",
params: [],
};

Expand Down Expand Up @@ -107,7 +109,7 @@ export function resilientEventListener(args: ResilientEventListenerArgs) {
if (requestIndex !== -1) {
subscriptionIds.push(parsedData.result);
logCb(`[${new Date().toISOString()}] Subscription to event established with subscription ID '${parsedData.result}'.`);
} else if (parsedData?.id === ping.id && parsedData?.result === true) {
} else if (parsedData?.id === ping.id && parsedData?.result && !isNaN(Number(parsedData.result))) {
logCb(`[${new Date().toISOString()}] Health check complete, subscription is still active.`)
if (pingTimeout) clearTimeout(pingTimeout);
} else if (parsedData?.method === 'eth_subscription' && subscriptionIds.includes(parsedData.params.subscription)) {
Expand Down
Loading