Switch blktap licensing to GPLv2 - #442
Conversation
|
I approve. |
|
Could we use SPDX license identifiers instead (https://spdx.dev/learn/handling-license-info/) ? |
|
Most of this appears to file header changes, which are not strictly necessary as the BSD license is compatible with the GPL and projects containing GPL code can safely contain files which are BSD licensed (the reverse of course not being true). Only the files which absolutely have to be GPL, i.e. the qcow2 management pieces that you will be adding, need to have GPL headers. The overall project license file should be updated to state that it is GPL2 with some BSD content. |
Version 3 of GPLv2 blanch pushed.
What do you think @MarkSymsCtx ? |
guzu
left a comment
There was a problem hiding this comment.
Beside the conflict with atomicio, which will ultimately be removed by this PR, it looks ok to me.
atomicio() is still available in VHD. Signed-off-by: Emmanuel Varagnat <emmanuel.varagnat@vates.tech>
The kernel detection function is use once in libaio setup. The consequence of this change is we don't support kernel older than 2.6.22. Remove code from Anthony Messerli as he didn't give his approval to switch his code to GPLv2. Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Please see the LICENSE file for BSD license and COPYING file for GPLv2 license. Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
I also update dates of the copyright to the latest year found in the history. Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
The Vates storage team would like to add support of VDI above 2TB.
To allow this we'd like to support Qcow2 format in the blktap component.
To help the development of this feature, we would like to import Qcow2 code from the Qemu implementation.
Since Qemu's code is licensed under GPLv2, we would like to also switch the global blktap license to GPLv2 to avoid license incompatibility.
Therefore, I am contacting all external contributors to get their approval on their commits to make this switch.
Only one contributor didn't answer (see update below).
In the meantime, this PR is open to review.
There are 2 parts in the PR:
atomicio.c,list.h,aio_genevents.c,autogen.sh)Update:
I add 2 patches on the PR: