Add security-related unit tests - #29
Merged
Merged
Conversation
Contributor
Author
|
The CI will fail until #28 is merged |
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
…a checks Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Otherwise long-running transactions would leak memory. Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
This failed before the XSA-483 patch, showing that the quota was not reset
after domain destruction:
FAIL Verify quota usage is as expected
Expected: `0'
Received: `4'
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
last-genius
force-pushed
the
asv/security
branch
from
April 30, 2026 10:40
1b004fd to
173095a
Compare
psafont
approved these changes
Apr 30, 2026
lindig
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a unit test making sure XSA-483 is fixed, and a few more verifying other security guarantees are ensured (history is bounded; concurrent transactions can't circumvent quota checks). Also adds tests for the
Unwatchcommand.