Skip to content

xenbus: Fix handling of requests with xsd_sockmsg.len = 0 for socket connections - #30

Merged
last-genius merged 1 commit into
xapi-project:mainfrom
last-genius:asv/fix-zero-request
Jul 14, 2026
Merged

xenbus: Fix handling of requests with xsd_sockmsg.len = 0 for socket connections#30
last-genius merged 1 commit into
xapi-project:mainfrom
last-genius:asv/fix-zero-request

Conversation

@last-genius

Copy link
Copy Markdown
Contributor

Following the report at https://lore.kernel.org/xen-devel/CAFLBxZaeTMcF4tcV45MJdCVx4A6qbzQdjKei_Quh_iLrtARVFA@mail.gmail.com/

Without this fix, the backend would be stuck waiting on the zero-sized body until the next request comes in.

Instead return the request immediately after reading the header, there's no need to wait for another call to .has_more_input and .input

…connections

Following the report at https://lore.kernel.org/xen-devel/CAFLBxZaeTMcF4tcV45MJdCVx4A6qbzQdjKei_Quh_iLrtARVFA@mail.gmail.com/

Without this fix, the backend would be stuck waiting on the zero-sized
body until the next request comes in.

Instead return the request immediately after reading the header, there's
no need to wait for another call to .has_more_input and .input

Reported-by: George Dunlap <dunlapg@umich.edu>
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
@last-genius

Copy link
Copy Markdown
Contributor Author

@last-genius
last-genius requested review from contificate and gthvn1 July 9, 2026 12:10

@gthvn1 gthvn1 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@last-genius
last-genius merged commit 754d719 into xapi-project:main Jul 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants