CA-414438 Defend against unexpected VDI name_description contents #766
Conversation
TimSmithCtx
force-pushed
the
private/timsmi/CA-414438
branch
from
ef0296a to
0c6b80d
Compare
libs/sm/core/util.py
Outdated
| return None | ||
| if type(obj) == str: | ||
| return obj | ||
| if type(obj) == dict and len(obj) == 0: |
There was a problem hiding this comment.
Following Python best practice, isinstance(obj, dict) is preferred over type(obj), but both are worked.
There was a problem hiding this comment.
Might as well tidy this up while we're making changes
There was a problem hiding this comment.
As we don't expect this to be the data type that we receive from xapi I wonder if we should log what we got as it might then allow for determining what went wrong?
There was a problem hiding this comment.
If we're fixing up the old practice here, also might as well remove the check for the type being "str" anyway, as it is redundant.
There was a problem hiding this comment.
Dangling bits of py2 -> py3 I suspect. It probably had basestring and unicode in there at some point.
It seems to be possible for a description field on an LV snapshot to be converted to a dictionary, which results in attempts to remove it from the MGT volume failing after it is deleted, which in turn results in a subsequent scan failing because an LV which should exist does not. It is not immediately clear how this ended up as a dictionary as it has been back and forth through XMLRPC a few times, but to solve the immediate issue, defend against such things. Signed-off-by: Tim Smith <[email protected]>
TimSmithCtx
force-pushed
the
private/timsmi/CA-414438
branch
from
0c6b80d to
d159e66
Compare
3 participants
It seems to be possible for a description field on an LV snapshot to be converted to a dictionary, which results in attempts to remove it from the MGT volume failing after it is deleted, which in turn results in a subsequent scan failing because an LV which should exist does not.
It is not immediately clear how this ended up as a dictionary as it has been back and forth through XMLRPC a few times, but to solve the immediate issue, defend against such things.