Sync up #769
Merged
Sync up #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long standing bug, introduced in ``` changeset: 1508:3c5a651ef2e4 user: Andrei Lifchits <[email protected]> date: Wed Feb 10 09:41:59 2010 -0800 summary: CA-36637: fix the free space requirements calculation for the inline- and leaf-coalesce; plus: ``` The act of coalescing a leaf VHD into a parent does not make any structural changes to the parentage of the VHD into which the data has been coalesced. This, unnecessarily, introduced a race where a VDI would report not having a parent until the next SR scan fixed it up. Signed-off-by: Mark Syms <[email protected]>
A previous change stopped the cleanup code unilaterally removing the `vhd-parent` configuration of the lef coalesced VHD which resulted in failures where VHDs that should have declared a parent no longer did until a subsequent SR scan restored the configuration value. This is the alternate mirror case where the leaf coalesce collapses the entire tree out and so the `vhd-parent` becomes redundant, again until a subsequent SR scan removes it. To satisfy both use cases remove the `vhd-parent` property if and only if the coalesced VHD has no parent. Signed-off-by: Mark Syms <[email protected]>
This reverts commit 2979937. Signed-off-by: Mark Syms <[email protected]>
No error logging is present in two error paths which make diagnosis difficult/impossible. Signed-off-by: Mark Syms <[email protected]>
If the iSCSI target exposes multiple LUNs which contain Volume Groups with the same ID as is required by an SR it is somewhat non-deterministic as to which actual PV will be used by the LVM subsystem when attaching the SR. To prevent unexpected failures, detect this condition and refuse to attach the SR. Signed-off-by: Mark Syms <[email protected]>
TimSmithCtx
approved these changes
Aug 19, 2025
LunfanZhang
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.