CA-413304: Restore VBD.unplug function to keep old functionality #6571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of 1a46f33. It retains the deactivate and detach functions introduced but restores the original unplug function so that the VBD_unplug atom is completely unchanged when xenops_vbd_plug_unplug_legacy=true instead of running deactivate followed by detach. This will fix the S(Does_not_exist) Xenopsd errors we are seeing in some VBD_unplug calls, until a fix for the split functions is found. Signed-off-by: Steven Woods <[email protected]>
|
Ring3 BVT+BST is all green: 220395 as is a job run of InstallerOptions (job 4356497) which is the job that was originally failing in CA-411477 before @BengangY 's fix. |
|
Do we retain the new functionality? This should be reviewed by @snwoods |
edwintorok
reviewed
Jul 4, 2025
edwintorok
approved these changes
Jul 4, 2025
I wrote it 😅 but yes, the new functionality is retained and will be active if xenopsd_vbd_plug_unplug_legacy=false. This change just means that when the legacy flag = true, the functionality will be identical to how it was before my original PR, instead of running the split deactivate/detach functions one after the other (which as we've found, seems to introduce a bug compared to the original functionality). |
BengangY
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of 1a46f33. It retains the deactivate and detach functions introduced but restores the original unplug function so that the VBD_unplug atom is completely unchanged when xenops_vbd_plug_unplug_legacy=true instead of running deactivate followed by detach.
This will fix the S(Does_not_exist) Xenopsd errors we are seeing in some VBD_unplug calls, until a fix for the split functions is found (I have created CA-413304 to track that issue)