-
Notifications
You must be signed in to change notification settings - Fork 292
Integrate QCOW2 VDI import-export #6593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
weird test failed, even though it passes locally and passed in my fork. i'm re-running it |
b9b5de1 to
6e41c2c
Compare
qcow-stream uses Lwt, which is not thread-safe, so we want to avoid using it in the xapi process. Create a CLI wrapper for calls to qcow-stream. Signed-off-by: Andrii Sultanov <[email protected]>
This patch allows to pass "qcow2" as a supported format when calling VDI export and import. Qcow_tool_wrapper is added as a helper that calls the Python script for export (conversion from raw to qcow2 stream) and the qcow-tool CLI tool (ocaml-qcow library) for import (conversion from qcow2 stream to raw). Signed-off-by: Guillaume <[email protected]> Signed-off-by: Andrii Sultanov <[email protected]>
Also add an mli file for qcow_tool_wrapper Signed-off-by: Andrii Sultanov <[email protected]>
6e41c2c to
c86e261
Compare
|
I am merging this. Please note the necessary change to the specfile given in the PR description. |
It also needs a new xs-opam release... |
Yes, indeed, preferrably with xapi-project/xs-opam#735 merged first. Sorry, I missed that there hasn't been a new release in a month+ |
Final touches for qcow2 VDI import/export - add it as one of the supported formats and plumb through the calls to the python script for export and
qcow-streamlibrary for import viaqcow_tool_wrapperandqcow-stream-tool.qcow-stream-toolis a thin wrapper executable overqcow-stream, so that xapi doesn't have to use Lwt code in its process (it's not thread-safe, see #6573 for the discussion on this)This was tested manually, confirmed to have the same behaviour as the previous version (#6573)
This PR requires the following additions to the specfile: