CA-412420: Set vdi-type When Create snapshot on SMAPIv3 SR #6596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the SMAPIv3 migration prepare step, it will create the VDI on the destination based on the source.
The source retrieves vdi_info via copy_into_sr → find_vdi → SR.scan2 → sr_scan2_impl → COWVolume.ls,
and sr_ls extracts all vdi_info from the database.
However, when creating a snapshot with COWVolume.snapshot on V3, the vdi-type is not stored in the database,
which causes getting an empty vdi-type and the migration prepare step to fail and result the folllowing error:
`\'INTERNAL_ERROR\', \'Failure("Unknown tag/contents")\']]);S()]]]))]))]))])`
This change adds a step to set vdi-type from the original VDI to the snapshot VDI to prevent this issue.
Signed-off-by: Lunfan Zhang[Lunfan.Zhang] <[email protected]>
psafont
approved these changes
Jul 18, 2025
changlei-li
approved these changes
Jul 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
the job from the merge was cancelled, was this intentional? |
I don`t think so, the job was cancelled due to a setup environment failure, operation issue? maybe re-trigger will work. |
|
Retried and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the SMAPIv3 migration prepare step, it will create the VDI on the destination based on the source. The source retrieves vdi_info via
copy_into_sr→find_vdi→SR.scan2→sr_scan2_impl→COWVolume.ls, andsr_lsextracts all vdi_info from the database.However, when creating a snapshot with
COWVolume.snapshoton V3, the vdi-type is not stored in the database, which causes getting an empty vdi-type and the migration prepare step to fail and result the folllowing error:\'INTERNAL_ERROR\', \'Failure("Unknown tag/contents")\']]);S()]]]))]))]))])This change adds a step to set vdi-type from the original VDI to the snapshot VDI to prevent this issue.