Skip to content

CP-309728 Move XS related PVS target key to xapi.conf #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

CP-309728 Move XS related PVS target key to xapi.conf #6706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ocaml/xapi/xapi_globs.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ let xen_livepatch_list = ref "/usr/sbin/xen-livepatch list"

let kpatch_list = ref "/usr/sbin/kpatch list"

let guest_service_keys = ref ["pvs_target/target_software_version"]
let guest_service_keys = ref []

let modprobe_path = ref "/usr/sbin/modprobe"

Expand Down Expand Up @@ -1437,6 +1437,11 @@ let other_options =
(fun s -> s)
(fun s -> s)
disable_dbsync_for
; gen_list_option "guest-service-keys"
"space-separated list of guest service keys to monitor in xenstore"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says space separated but other lists are using a comma. I would prefer this to be consistent. A comma would be more shell friendly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see at least three other lists that state they are space-separated, xenopsd_queues seems to be the exception

(fun s -> s)
(fun s -> s)
guest_service_keys
; ( "xenopsd-queues"
, Arg.String (fun x -> xenopsd_queues := String.split ',' x)
, (fun () -> String.concat "," !xenopsd_queues)
Expand Down
3 changes: 3 additions & 0 deletions scripts/xapi.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,3 +397,6 @@ xen_livepatch_list = "/usr/sbin/xen-livepatch list"

# The command to query current kernel patch list
kpatch_list = "/usr/sbin/kpatch list"

# Guest service keys to monitor in xenstore data
guest-service-keys = pvs_target/target_software_version
Loading