Skip to content

Conversation

gthvn1
Copy link
Contributor

@gthvn1 gthvn1 commented Oct 15, 2025

No description provided.


The metrics used by `perfmon` are collected by the `xcp-rrdd` daemon. The `xcp-rrdd` daemon is a component of XAPI responsible for collecting metrics and storing them as Round-Robin Databases (RRDs).

A XAPI plugin also exists, providing the functions `stop`, `start`, `restart`, `refresh`, and `debug_mem`. The `stop`, `start`, and `restart` functions appear to be deprecated, as they do not use systemd to manage the state of the `perfmon` daemon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could the deprecated functions be dropped completely, then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes in fact I saw that @last-genius removed them few days ago :)... I will remove this 👍

'<config><variable><name value="cpu_usage"/><alarm_trigger_level value="0.5"/></variable></config>'
```

- The XML string can include multiple <variable> nodes allowed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would benefit from details what legal values are for each of these:

  • alarm_priority
  • regular expression syntax is not unique; several standards exist

You could point to the code where this is implemented.

Copy link
Contributor Author

@gthvn1 gthvn1 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean adding that alarm_priority will be the priority of the generated message right?

Oh I didn't know about regex. And I guess that you don't think about pattern related to the config tag like it is done here: https://github.com/xapi-project/xen-api/blob/master/python3/bin/perfmon#L871
I don't know how exactly regex are used but for sure I will try to improve this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants