Skip to content

Conversation

robhoes
Copy link
Member

@robhoes robhoes commented Oct 16, 2025

No description provided.

@robhoes robhoes force-pushed the ocaml5-ci branch 2 times, most recently from c88f3a2 to f49572c Compare October 16, 2025 15:43
@robhoes
Copy link
Member Author

robhoes commented Oct 16, 2025

The new ocaml_version parameter on setup-xapi-environment causes some of the "expected" checks to be out of sync again... That needs to be fixed in the github config if this PR is approved. The "OCaml tests" are all passing, for 4.14.2 as well as 5.3.0.

@psafont
Copy link
Member

psafont commented Oct 17, 2025

At this point it's probably the right thing to drop the sourcing of https://github.com/xapi-project/xs-opam/blob/master/tools/xs-opam-ci.env in .github/workflows/setup-xapi-environment/action.yml
That's how the ocaml version used to be controlled in CI

@psafont
Copy link
Member

psafont commented Oct 17, 2025

We need to change the required checks because a new parameter got added to the matrix before merging this. Now there's a check that will never run, an another that runs should be required.

We probably want to merge the open feature PRs before doing this

@robhoes robhoes added this pull request to the merge queue Oct 17, 2025
Merged via the queue into xapi-project:master with commit 539a08b Oct 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants