CA-422272: Validate pool ref in pool SSH helpers - #7210
Conversation
Pool.{enable,disable}_ssh and the shared timeout/auto-mode
helpers ignored their pool ref, so an invalid handle disabled
SSH pool-wide instead of raising HANDLE_INVALID. Validate self
in Ssh.operate.
Signed-off-by: Bengang Yuan <bengang.yuan@citrix.com>
|
This seems strange, that handles aren't verified in another layer before this point |
Actually, there is function |
It might be worth changing the code to raise it there, but it needs to be well-tested to see what calls are affected. |
Yes, there are so many function using |
Pool.{enable,disable}_ssh and the shared timeout/auto-mode helpers ignored their pool ref, so an invalid handle disabled SSH pool-wide instead of raising HANDLE_INVALID. Validate self in Ssh.operate.