Skip to content

[master] Update ocaml-qcow to 0.14.0 - #768

Merged
last-genius merged 3 commits into
xapi-project:masterfrom
last-genius:asv/qcow-master
Jun 11, 2026
Merged

[master] Update ocaml-qcow to 0.14.0#768
last-genius merged 3 commits into
xapi-project:masterfrom
last-genius:asv/qcow-master

Conversation

@last-genius

@last-genius last-genius commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This is a forward-port of #755 (with the exception of commits later reverted in #766).

This PR's CI will fail as xapi hasn't been updated to follow new interfaces yet, so the xapi PR (xapi-project/xen-api#7106) needs to be merged first

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
(cherry picked from commit 8f88f36)
@psafont

psafont commented Jun 1, 2026

Copy link
Copy Markdown
Member

The packages fail to be resolved under ocaml 5.4.1: https://github.com/xapi-project/xs-opam/actions/runs/26754975135/job/78852365779?pr=768#step:11:25

Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
(cherry picked from commit 1413bb2)
@last-genius

Copy link
Copy Markdown
Contributor Author

The packages fail to be resolved under ocaml 5.4.1: https://github.com/xapi-project/xs-opam/actions/runs/26754975135/job/78852365779?pr=768#step:11:25

Added both lwt_ppx.5.9.1 and 5.9.3

pull Bot pushed a commit to acefei/xen-api that referenced this pull request Jun 11, 2026
…7106)

This is a forward-port of
xapi-project#6895 (with the exception of
commits later reverted in
xapi-project#7030 and
xapi-project#7022).

Changes to VHD code are gated behind a feature flag (with previous
behaviour kept by default). XCP-ng has been running the new VHD and QCOW
code for a while now with no issues.

This PR needs to be merged before the corresponding xs-opam PR
(xapi-project/xs-opam#768)
@psafont

psafont commented Jun 11, 2026

Copy link
Copy Markdown
Member

Did something change recently? Looks like there might be an undeclared dependency

 #=== ERROR while compiling xapi-storage-cli.master ============================#
# context              2.5.1 | linux/arm64 | ocaml-base-compiler.4.14.2 | git+file:///home/runner/work/xs-opam/xs-opam
# path                 ~/work/xs-opam/xs-opam/_opam/.opam-switch/build/xapi-storage-cli.master
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p xapi-storage-cli -j 3 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/xapi-storage-cli-10573-9405dd.env
# output-file          ~/.opam/log/xapi-storage-cli-10573-9405dd.out
### output ###
# File "ocaml/xapi/dune", line 179, characters 2-19:
# 179 |   rrdd-plugin.local
#         ^^^^^^^^^^^^^^^^^
# Error: Library "rrdd-plugin.local" not found.

@last-genius

Copy link
Copy Markdown
Contributor Author

Did something change recently? Looks like there might be an undeclared dependency

 #=== ERROR while compiling xapi-storage-cli.master ============================#
# context              2.5.1 | linux/arm64 | ocaml-base-compiler.4.14.2 | git+file:///home/runner/work/xs-opam/xs-opam
# path                 ~/work/xs-opam/xs-opam/_opam/.opam-switch/build/xapi-storage-cli.master
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p xapi-storage-cli -j 3 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/xapi-storage-cli-10573-9405dd.env
# output-file          ~/.opam/log/xapi-storage-cli-10573-9405dd.out
### output ###
# File "ocaml/xapi/dune", line 179, characters 2-19:
# 179 |   rrdd-plugin.local
#         ^^^^^^^^^^^^^^^^^
# Error: Library "rrdd-plugin.local" not found.

I re-ran the job and it passed....

@last-genius
last-genius merged commit 50db954 into xapi-project:master Jun 11, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants