[tracing] Propagate TraceID to the backend. Create a new setupEnv span. Fix span hierarchy#604
[tracing] Propagate TraceID to the backend. Create a new setupEnv span. Fix span hierarchy#604
Conversation
|
size-limit report 📦
|
|
Your pull request has been published to npm. You can install it by running: To test the CLI, run: |
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
| @@ -1,19 +1,32 @@ | |||
| export type AttributeDictionary = Record<string, string | number | boolean | undefined>; | |||
|
|
|||
| export type SetAttributesFn = ( | |||
There was a problem hiding this comment.
this one is unused it seems
There was a problem hiding this comment.
Yeah these are publicly exported types, so doesn't matter if we don't use them internally.
|
Looking good! The hierarchy of spans is maintained till the backend 👌 One downside with the final refactor is that we lost the parent Span, and now we have a bunch of top-level spans that belong to the same suite but we don't have a way to point to "all of them". |
|
I will look at it! Thanks @sgirones |
This PR tackles three main issues:
spanfor the setup actions: this change traces the setup actions performed by everytest suiteand links thesetup spanto thesuite spanTODO:
test caseare linked to thesuite spaninstead of thetest span. The test span created in thebeforeEachhook needs to be activated before the test code runs.