Conversation
Signed-off-by: Alexis Rico <sferadev@gmail.com>
🦋 Changeset detectedLatest commit: 355c9c3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
Contributor
size-limit report 📦
|
Contributor
|
Your pull request has been published to npm. You can install it by running: To test the CLI, run: |
Signed-off-by: Alexis Rico <sferadev@gmail.com>
SferaDev
commented
Nov 25, 2022
|
|
||
| if (!semver.satisfies(installedVersion, `^${sdkVersion}`)) { | ||
| return this.error( | ||
| `The installed version of @xata.io/client (${installedVersion}) does not satisfy the required version (${sdkVersion}). Please update your package.json.` |
Member
Author
There was a problem hiding this comment.
Suggested change
| `The installed version of @xata.io/client (${installedVersion}) does not satisfy the required version (${sdkVersion}). Please update your package.json.` | |
| `The installed version of the SDK (${installedVersion}) does not satisfy the CLI version (${sdkVersion}). Please update the packages to run the codegen.` |
Member
Author
There was a problem hiding this comment.
I would like to:
- If SDK is outdated, offer to update it with a question
- If CLI is outdated, show command to update (or when we have auto update, offer to update it with a question)
Also:
- Add
--forceto ignore the errors and continue if user knows what they're doing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the CLI and codegen use the same version or a semver compatible one.
Criteria: