fix(docs): correct webmanifest name and guard deploy job against PR runs#424
Merged
Conversation
v-tan
force-pushed
the
seo/docs-ecosystem-nav
branch
from
05341b3 to
8ddff54
Compare
v-tan
changed the title
- Replace UTF-8 em dash in .lintr comment with ASCII dash; lintr 3.3.0 chokes on multi-byte characters in config files via sprintf bytes encoding - Replace inline triple backticks in CodeBlockStyle::Backticks doc comment with triple backticks text to avoid ExDoc treating them as unclosed code fence
v-tan
force-pushed
the
seo/docs-ecosystem-nav
branch
from
b3b6750 to
f24f7f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
"Xberg"from the initial template commit; corrected to"html-to-markdown"deployjob had no branch guard so it attempted a GitHub Pages deploy on every PR, which the environment protection rule always rejected; addedif: github.event_name == 'push' && github.ref == 'refs/heads/main'Also removes a stray double blank line in
docs/overrides/main.html.