refactor: playlist position tracking using player properties#1054
Merged
SyncedSynapse merged 1 commit intoxbmc:masterfrom Nov 11, 2025
Merged
Conversation
Member
|
Looks good, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes playlist position tracking by using
PlayerType.PropertyValue.positiondirectly instead of searching through all playlist items by ID comparison. The current implementation uses an O(n) loop to find the active item, but since the player already provides the position, we can access it directly with O(1) complexity. This change improves performance (especially for large playlists), simplifies the code, and maintains all existing functionality including drag detection and UI selection behavior.closes #1053