Conversation
|
I don't understand what's the point of mixing UIKit (the view controller that you have) and SwiftUI. Choose a single UI framework. |
|
No worries at all - most of this was attempting to understand how to implement the feature. I'll update as soon as I can; before UI I want to work out how best to send the JSON-RPC request. There's actually no UI whatsoever that has been implemented yet. |
main app already has such code. Extract it into a (dynamic) framework and link it to both app and extension. |
|
Yeah I was looking at the tcpJSONRPC class - will investigate and hopefully update this pull request again soon. |
|
Will it rely on SendToKodi ? |
I don't believe it's needed |
It could reduce the development effort. Mostly you just send it a URL and it handles the right way to play it. It can play more than just YouTube. It already works well with the Kore app on Android. |
Adds Share Extension and initial logic to check if url is from YouTube - call of JSONRPC API needs integration.
Description
These changes make the kodi remote app appear when sharing URLs. At the moment, choosing to share doesn't actually do anything. I imagine before merging a SwiftUI View will need to be made in order to choose between whether the use wants to queue or play the item immediately
Summary for release notes
Adds share extension for YouTube urls to kodi remote