Skip to content

Rework SettingsValuesVC #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kambala-decapitator merged 9 commits into from
Nov 11, 2025
Merged

Rework SettingsValuesVC #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b89f3ba
Fix handling settings reporting as "slider"
wutschel Nov 1, 2025
99bc692
Show the option label and not the value
wutschel Nov 1, 2025
6f5594e
Fix formatting for custom button label
wutschel Nov 2, 2025
d3cad0e
Prepare to handle float/integer as slider label
wutschel Nov 2, 2025
39c9e6f
Make slider label consider settingValueType
wutschel Nov 2, 2025
60924ab
Refactor settings processing
wutschel Nov 2, 2025
6ed47a4
Show units for fmt-like string format
wutschel Nov 2, 2025
8d2e575
Used fixed cell layout to make sure cellHeight is correclty calculated
wutschel Nov 2, 2025
7d31af7
fixup: braces
wutschel Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions XBMC Remote/SettingsValuesViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,20 @@ typedef NS_ENUM(NSInteger, SettingType) {
SettingTypeUnsupported,
};

typedef NS_ENUM(NSInteger, SettingValueType) {
SettingValueTypeBoolean,
SettingValueTypeInteger,
SettingValueTypeNumber,
SettingValueTypeString,
SettingValueTypeAction,
SettingValueTypeList,
SettingValueTypePath,
SettingValueTypeAddon,
SettingValueTypeDate,
SettingValueTypeTime,
SettingValueTypeUnknown,
};

@interface SettingsValuesViewController : UIViewController <UITableViewDelegate, UITableViewDataSource, UITextFieldDelegate, UIGestureRecognizerDelegate> {
CGFloat cellHeight;
NSMutableArray *settingOptions;
Expand All @@ -33,6 +47,8 @@ typedef NS_ENUM(NSInteger, SettingType) {
UILabel *scrubbingRate;
UILabel *footerDescription;
BOOL fromItself;
SettingValueType settingValueType;
NSDictionary *valueTypeLookup;
}

- (id)initWithFrame:(CGRect)frame withItem:(id)item;
Expand Down
Loading