Rework server list

[wutschel]

Description

This PR applies two main changes:

Introduce updateServerCellStatus

The new method updateServerCellStatus updates the server list cell's connection status icon only. This allows to reduce the amount of releadData calls, which was before used to do this.

Introduce noFoundLabel

The UILabel noFoundLabel is used to signal an empty server list. It is faded in/out depending on the state of the list. This allows to remove the former solution which based on a dummy cell.

Other smaller changer were related to coding styles and minor refactoring.

Summary for release notes

Improvement: Using UILabel to signal "No saved hosts found" instead of creating a dummy cell
Improvement: Avoid calling reloadData by only updating connection status icon when needed
Maintenance: Coding styles and minor refactoring

[kambala-decapitator]

although subclassing UILabel isn't really needed when you can do just

@implementation UILabel (NoFound)
- (instancetype)initAsNoFoundWithFrame:(CGRect)frame {
  self = [self initWithFrame:frame];
}

// or even instead of the initializer:
- (void)configureAsNoFound {
  ...
}
@end

[kambala-decapitator]

Suggested change

	@interface NoFoundLabel : UILabel;
	@interface NoFoundLabel : UILabel

[kambala-decapitator]

Suggested change

	- (id)initWithFrame:(CGRect)frame;
	- (instancetype)initWithFrame:(CGRect)frame;

[kambala-decapitator]

Suggested change

	- (id)initWithFrame:(CGRect)frame {
	- (instancetype)initWithFrame:(CGRect)frame {

[kambala-decapitator]

please also fix conflicts

[wutschel]

@implementation UILabel

Wouldn't this require to define this again several times, for controller it is used in? I thought of either subclassing (as I did now) or adding an extension (also 2 new files). You have different solution in mind?

[kambala-decapitator]

I gave you an example of extension :) without the interface declaration (which is trivial to create) to type less

[wutschel]

I gave you an example of extension :) without the interface declaration (which is trivial to create) to type less

Yes, I recognized this 😉 My question is about where to place such extension? If I need to declare this separately for each controller, there's still code duplication.

[kambala-decapitator]

no, of course no duplication. Simply place it in separate files just like you did with the other extensions.

btw you can also include all extensions in PCH to have them accessible everywhere.

[wutschel]

FInally, I went for a standard, full-blown extension. Will use the same pattern for future extensions. I have several extension to come with next PRs.

[kambala-decapitator]

FYI you're not limited to a single extension for a given class, you can have as many as you want.

[wutschel]

FYI you're not limited to a single extension for a given class, you can have as many as you want.

Yep, this is what I will do with #1425 and #1428. But will need to move them from Utilities to dedicated files.

[wutschel]

You're ok with the solution? In this case I would make this ready for merge.