Bugfix: Make playlist toolbar work again on iPad#1460
Open
wutschel wants to merge 1 commit intoxbmc:masterfrom
Open
Bugfix: Make playlist toolbar work again on iPad#1460wutschel wants to merge 1 commit intoxbmc:masterfrom
wutschel wants to merge 1 commit intoxbmc:masterfrom
Conversation
This fixes the issue that the playlist toolbar was not reacting to touches anymore. In consequence, the calculation of the maximum allowed vertical position within leftMenuView must be corrected as well.
Review timed out before producing output. Scheduling a reduced-scope retry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a regression caused by #1453 and reported in this forum post.
Extend
leftMenuViewto include the playlist toolbar. This fixes the issue that the playlist toolbar was not reacting to touches anymore on iPad. In consequence, the calculation of the maximum allowed vertical position withinleftMenuViewmust be corrected as well.This PR was tested on iPad (8G) and iPad Pro (12") 6G simulators.
Summary for release notes
Bugfix: Make playlist toolbar work again on iPad