Improvement: Display TV Show specials in logical order inside seasons#1468
Open
wutschel wants to merge 2 commits intoxbmc:masterfrom
Open
Improvement: Display TV Show specials in logical order inside seasons#1468wutschel wants to merge 2 commits intoxbmc:masterfrom
wutschel wants to merge 2 commits intoxbmc:masterfrom
Conversation
Available since Kodi 12 (Frodo).
Check for >0 to cover Kodi versions which defaulted to 0. Adds a copy using the "special sort" attributes. Items are enriched with "Sx" track number scheme and a flag to support sorting in right order. This way specials show under "Specials" (season 0) as well as sorted into the seasons.
Collaborator
Author
|
btw, I am quite sure this also fixes potential sorting problems with episodes. I have seen while testing this PR, that sometimes the order of episodes was wrong. |
Review timed out before producing output. Retry skipped due to frequent timeouts for this repo/author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #57.
Usually, TV Show specials are listed under season 0. Many TV Shows have special episodes which are important to watch in logical order, ex. "Doctor Who". Kodi is able to display special episodes in both season 0 and in the correct place inside the common seasons. This PR implements the same functionality based on information shared within #57 and links provided from there.
To allow correct logical sorting, the Kodi API shares
specialsortseasonandspecialsortepisode, which represent the logical position of the special episode inside the common seasons. The app does now request this information toshow special episodes in both season 0 and the logical position. 3-staged sorting is applied to ensure the special episodes are added in correct order to the desired position.
To differentiate special episodes from common episodes the naming convention for track numbers and episode IDs is adapted. It follows Kodi's implementation by using "Sx" (x = special episode) which clearly visualizes the type of episode.
Screenshots, suing dummy database with episodes from "Doctor Who":

Summary for release notes
Improvement: Display TV Show specials in logical order inside seasons