Skip to content

smoke: fork write flow validation#22

Closed
keithah wants to merge 1 commit intoxbmc:mainfrom
keithah:smoke/fork-write-kodiai-20260211
Closed

smoke: fork write flow validation#22
keithah wants to merge 1 commit intoxbmc:mainfrom
keithah:smoke/fork-write-kodiai-20260211

Conversation

@keithah
Copy link
Copy Markdown
Member

@keithah keithah commented Feb 11, 2026

Smoke PR for fork plan/apply fallback validation in xbmc/kodiai.

Copilot AI review requested due to automatic review settings February 11, 2026 04:38
@keithah
Copy link
Copy Markdown
Member Author

keithah commented Feb 11, 2026

@kodiai plan: append one line 'fork apply smoke' to docs/smoke/xbmc-kodiai-write-flow.md

Comment thread .kodiai.yml
write:
enabled: true
allowPaths:
- docs/**
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allowPaths pattern docs/** will match any path starting with docs/, but it's worth confirming this is the intended behavior. If the intent is to only allow modifications within the docs directory and its subdirectories, this pattern is correct. However, if there are specific subdirectories within docs/ that should be excluded (e.g., docs/internal/ or sensitive documentation), those should be explicitly denied or this pattern should be more restrictive.

@kodiai
Copy link
Copy Markdown

kodiai Bot commented Feb 11, 2026

Kodiai Review Summary

Minor
.kodiai.yml (11): Overly broad allowPaths pattern may permit unintended write access
The docs/** pattern allows write access to all files under the docs directory without exclusions. If there are any sensitive or internal documentation subdirectories that should remain protected during smoke testing, they should be explicitly excluded or the pattern should be more restrictive.

@keithah
Copy link
Copy Markdown
Member Author

keithah commented Feb 11, 2026

@kodiai apply: append one line 'fork apply smoke' to docs/smoke/xbmc-kodiai-write-flow.md

@kodiai
Copy link
Copy Markdown

kodiai Bot commented Feb 11, 2026

kodiai response

Done. I've appended the line fork apply smoke to docs/smoke/xbmc-kodiai-write-flow.md.

Plan:
Intent: append one line to the smoke test doc

Files:

  • docs/smoke/xbmc-kodiai-write-flow.md

Steps:
(1) Read docs/smoke/xbmc-kodiai-write-flow.md
(2) Append 'fork apply smoke' as the final line
(3) Save the change

The file has been updated locally. Reply with apply: <same request> to commit and push this change to the PR branch.

@kodiai
Copy link
Copy Markdown

kodiai Bot commented Feb 11, 2026

kodiai response

Opened PR: #23

kodiai Bot added a commit that referenced this pull request Feb 11, 2026
kodiai-write-output-key: kodiai-write-output:v1:inst-109141824:xbmc/kodiai:pr-22:comment-3882074909:keyword-apply
deliveryId: ae884ae0-0703-11f1-91df-c2559c455428
@kodiai kodiai Bot mentioned this pull request Feb 11, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds repo configuration and documentation updates to support a smoke validation of fork vs same-repo write-mode behavior in xbmc/kodiai.

Changes:

  • Document the smoke-test baseline in the xbmc/kodiai write-flow guide.
  • Enable mention handling and write-mode in .kodiai.yml, restricting writes via allowPaths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/smoke/xbmc-kodiai-write-flow.md Adds a baseline note for the fork smoke branch validation doc.
.kodiai.yml Enables mention + write-mode and restricts write scope to docs/**.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .kodiai.yml
write:
enabled: true
allowPaths:
- docs/**
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write.allowPaths is currently set to docs/**, which permits write-mode changes anywhere under docs/. For a smoke test, consider narrowing this to the minimal scope needed (e.g., docs/smoke/** or specific files) to reduce the blast radius if someone triggers @kodiai apply: unintentionally.

Suggested change
- docs/**
- docs/smoke/**

Copilot uses AI. Check for mistakes.
Comment thread .kodiai.yml
Comment on lines +8 to +10
write:
enabled: true
allowPaths:
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabling write.enabled: true on the default branch allows mention-driven commits to land automatically (within the allowPaths policy). If this PR is only meant for a temporary smoke validation, consider keeping write-mode disabled on main and enabling it only on the smoke branch/PR under test, or time-boxing/reverting it afterward to reduce ongoing operational/security exposure.

Copilot uses AI. Check for mistakes.
@keithah keithah closed this Feb 11, 2026
@keithah keithah deleted the smoke/fork-write-kodiai-20260211 branch February 11, 2026 06:25
@keithah
Copy link
Copy Markdown
Member Author

keithah commented Feb 12, 2026

phase-29 feedback capture verification trigger

@keithah
Copy link
Copy Markdown
Member Author

keithah commented Feb 12, 2026

phase-29 post-deploy feedback sync trigger

@keithah
Copy link
Copy Markdown
Member Author

keithah commented Feb 12, 2026

phase-29 feedback sync trigger after startup

@keithah
Copy link
Copy Markdown
Member Author

keithah commented Feb 12, 2026

phase-29 live log capture trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants