Import Amiga Competition Pro controller add-on

[garbear]

Description

This PR imports the new Amiga "Competition Pro" joystick added in kodi-game/controller-topology-project#428.

Needed by the Amiga UAE emulator after kodi-game/game.libretro.uae#10.

pngs have been crushed by pngcrush -brute -ow.

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

[kodiai]

Kodiai Review Summary

What Changed

This PR imports the Amiga Competition Pro joystick controller add-on, defining its button layout and localization strings.

Reviewed: core logic

Strengths

• ✅ PNG images have been optimized with pngcrush as documented in the PR description
• ✅ Consistent file structure following established repository patterns (addon.xml, resources/layout.xml, strings.po)
• ✅ Clear documentation with proper image attribution in the disclaimer at addon.xml:14

Observations

Impact

[MAJOR] game.controller.amiga.pro.joystick/resources/layout.xml (19-27): Analog controls defined for digital-only hardware
Causes incorrect controller capabilities when emulators load this definition. The Competition Pro was a digital joystick without analog sticks or triggers.

Verdict

🔴 Address before merging -- 1 blocking issue(s) found

Review Details

• Files reviewed: 5
• Lines changed: +142 -0
• Profile: balanced (auto, lines changed: 142)
• Author: newcomer (adapted tone)
• Findings: 0 critical, 1 major, 0 medium, 0 minor (includes 1 from summary observations)
• Review completed: 2026-03-20T02:15:05.215Z
• Keyword parsing:
  • focus hints: [GAME.CONTROLLER.AMIGA.PRO.JOYSTICK]

[garbear]

MAJOR impact probably isn't an issue, analog triggers are quantized to digital buttons for libretro when needed.

[romanvm]

Merging this although I have no idea how it works :)