Skip to content

[metadata.tvshows.themoviedb.org.python] v1.7.5#596

Merged
pkscout merged 1 commit intoxbmc:nexusfrom
pkscout:nexus-tmdb-tvshows
Mar 1, 2026
Merged

[metadata.tvshows.themoviedb.org.python] v1.7.5#596
pkscout merged 1 commit intoxbmc:nexusfrom
pkscout:nexus-tmdb-tvshows

Conversation

@pkscout
Copy link
Copy Markdown
Member

@pkscout pkscout commented Feb 28, 2026

Description

  • added option to split keyart from posters
  • fixed sorting and trimming so that landscape and keyart aren't deleted

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

@kodiai
Copy link
Copy Markdown

kodiai bot commented Feb 28, 2026

Kodiai Review Summary

What Changed

Adds option to split keyart from posters and fixes sorting/trimming to preserve landscape and keyart images.

Reviewed: core logic, docs

Strengths

  • ✅ Properly refactored image categorization from inline filtering to dedicated type splitting in _sort_image_types()
  • ✅ Added user-facing setting with proper localization for keyart categorization

Observations

Impact

[MAJOR] metadata.tvshows.themoviedb.org.python/libs/tmdb.py (488, 498): Inconsistent null-check patterns risk type errors
Line 488 uses != None comparison while line 498 uses == None. In Python, is not None and is None are the preferred idioms for null checks. The current mixed pattern with != and == works but violates PEP 8 style and is less idiomatic.

Preference

[MINOR] metadata.tvshows.themoviedb.org.python/libs/tmdb.py (488, 498): Mixed comparison operators for null checks
Optional: Use is not None instead of != None and is None instead of == None for consistency with Python best practices.

Verdict

🟡 Ready to merge with minor items -- Optional cleanup suggestions below (no blockers)

Review Details
  • Files reviewed: 7
  • Lines changed: +45 -11
  • Profile: strict (auto, lines changed: 56)
  • Author: core (adapted tone)
  • Findings: 0 critical, 1 major, 0 medium, 1 minor (includes 2 from summary observations)
  • Review completed: 2026-02-28T18:47:43.252Z
  • Keyword parsing:
    • focus hints: [METADATA.TVSHOWS.THEMOVIEDB.ORG.PYTHON]

- added option to split keyart from posters
- fixed sorting and trimming so that landscape and keyart aren't deleted

fixes from KodiAI review
@pkscout
Copy link
Copy Markdown
Member Author

pkscout commented Feb 28, 2026

@kodiai review

Copy link
Copy Markdown

@kodiai kodiai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kodiai response

Decision: APPROVE

Issues: none

@pkscout pkscout merged commit 32705d7 into xbmc:nexus Mar 1, 2026
1 check passed
@pkscout pkscout deleted the nexus-tmdb-tvshows branch March 6, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant