Skip to content

#40 - Usage inside scrollview issue fixed#112

Open
krunal-lw wants to merge 3 commits into
xcarpentier:masterfrom
krunal-lw:bugfix/40
Open

#40 - Usage inside scrollview issue fixed#112
krunal-lw wants to merge 3 commits into
xcarpentier:masterfrom
krunal-lw:bugfix/40

Conversation

@krunal-lw

@krunal-lw krunal-lw commented Aug 30, 2022

Copy link
Copy Markdown

Hello Xavier Carpentier, I have fixed scroll issue in plugin, so now we can pass scrollView ref with start function and plugin automatically scroll to the target element

@Drzaln

Drzaln commented Sep 1, 2023

Copy link
Copy Markdown

Hi @xcarpentier
can you check this PR?

@imamrobani

Copy link
Copy Markdown

need this, please approve and merge

@CrisRonda

Copy link
Copy Markdown

Hi, is this still under review?

@sssajjad007 sssajjad007 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls merge this

@Krollitte

Copy link
Copy Markdown

@xcarpentier, please, dude, we need this

@mtebele

mtebele commented Feb 17, 2025

Copy link
Copy Markdown

Please merge!

@mtebele

mtebele commented Feb 18, 2025

Copy link
Copy Markdown

Hi guys, find attached the patch file :)

rn-tourguide-npm-3.3.2-95bf1b8385.patch

const setCurrentStep = async (key: string, step?: IStep) =>
new Promise<void>(async (resolve) => {
if (scrollRef && step) {
await step.wrapper.measureLayout(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably due to the age of the PR and the differences in react-native since then, but this needs to be step.target, or this will throw with the following error if someone wraps a composite component with a TourGuideZone: ERROR Warning: ref.measureLayout must be called with a ref to a native component.

@Prince-Sarfo

Copy link
Copy Markdown

Hi guys, find attached the patch file :)

rn-tourguide-npm-3.3.2-95bf1b8385.patch

The patch is not working for me

@Prince-Sarfo

Copy link
Copy Markdown

Please merge it

@Prince-Sarfo

Copy link
Copy Markdown

Hi guys, find attached the patch file :)

rn-tourguide-npm-3.3.2-95bf1b8385.patch

@mtebele How do I get the patch to work

@mtebele

mtebele commented Jun 11, 2025

Copy link
Copy Markdown

Hi guys, find attached the patch file :)

rn-tourguide-npm-3.3.2-95bf1b8385.patch

@mtebele How do I get the patch to work

  1. Place the file inside the .yarn/patches/ directory.

  2. Add this to your package.json:

{
"dependencies": {
"rn-tourguide": "patch:rn-tourguide@npm:3.3.2#./.yarn/patches/rn-tourguide-npm-3.3.2-95bf1b8385.patch"
}
}

  1. Run yarn install

@Prince-Sarfo

Prince-Sarfo commented Jun 11, 2025

Copy link
Copy Markdown

Screenshot 2025-06-11 163458

Hi guys, find attached the patch file :)
rn-tourguide-npm-3.3.2-95bf1b8385.patch

@mtebele How do I get the patch to work

  1. Place the file inside the .yarn/patches/ directory.
  2. Add this to your package.json:

{ "dependencies": { "rn-tourguide": "patch:rn-tourguide@npm:3.3.2#./.yarn/patches/rn-tourguide-npm-3.3.2-95bf1b8385.patch" } }

  1. Run yarn install

It seems the start in the patch too does not accept a ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.