fix: prevent mkdef partial writes on validation errors#7558
Merged
Obihoernchen merged 1 commit intoMay 7, 2026
Merged
Conversation
Obihoernchen
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a long-standing mkdef failure mode where a command could report a validation error but still leave behind a partial object definition.
The reported case was:
mkdef -t node -o node1 groups=compute bmc=10.0.0.1Because bmc depends on a valid mgt value, this should fail cleanly. Before this change, mkdef could still create or modify part of the node, which left the user with a broken object and made the corrected command fail on retry.
The fix makes validation failures block writes for the affected object. It also preserves existing objects when mkdef -f fails validation, instead of deleting or partially replacing them first.
Fixes #3706