fix: skip disabled IPMI user slots in bmcsetup#7559
Merged
Conversation
bmcsetup iterated every user slot and retried ipmitool user disable for slots that were already disabled. Lenovo XCC reports those attempts as Invalid data field in request, so discovery can spend minutes retrying no-op disables. Read the current user table once per BMC, keep the old fallback when the table cannot be read, and disable only non-target slots whose IPMI Msg flag is true. Also use the loop's current username when resolving the target slot and keep the intended userslot 2 fallback assignment. Fixes xcat2#5065
Obihoernchen
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was observed that bmcsetup currently walks every IPMI user slot and tries to disable each non-target slot. On Lenovo XCC, disabled or empty slots can return Invalid data field in request, so the script retries the same no-op command until timeout. With several disabled slots, that can add minutes to discovery and BMC setup, which is inefficient at best.
This change addresses the issue by reading the current IPMI user table first, removing the configured xCAT BMC user slot from the disable list, then disabling only non-target slots whose IPMI Msg flag is true.
If the user table cannot be read, the script falls back to the old behavior instead of silently skipping everything.
Fixes #5065