fix: detect dnf as package manager in ospkgs and otherpkgs postscripts#7560
Merged
Obihoernchen merged 1 commit intoMay 7, 2026
Merged
Conversation
On RHEL 9.x minimal installs, the yum package may not exist as a separate RPM — only dnf is present with /usr/bin/yum as a symlink. The previous detection using rpm -q yum would fail, causing hasyum to remain 0 and skipping repo file creation entirely. Replace rpm -q based detection with executable checks for /usr/bin/dnf and /usr/bin/yum. Introduce yumcmd variable to carry the actual command name through all package operations instead of hardcoding yum. Fixes: xcat2#7497
Obihoernchen
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On RHEL 9.x minimal installs, the yum package may not exist as a separate RPM. So, only
dnfis present with/usr/bin/yumas a symlink. The previous detection usingrpm -q yumwould fail, causing$hasyumto remain false and skipping repo file creation entirely.This PR replaces
rpm -qbased detection with executable checks for/usr/bin/dnfand/usr/bin/yum. Introduce yumcmd variable to carry the actual command name through all package operations instead of hardcodingyum.$yumcmdcan be considered ugly since it may carrydnfbut it was the choice to keep intent.Fixes: #7497