feat: support configurable ISC OMAPI TSIG policy#7563
Merged
Conversation
Add a shared OMAPI policy helper for ISC DHCP and DDNS so administrators can select the key name, signing algorithm, and omshell path from the site table while preserving the existing xcat_key hmac-md5 default. Keep local ISC updates from hanging indefinitely when omshell does not exit, and use a static host-declaration fallback for local Ubuntu ISC releases where omshell is unstable for xCAT host updates. Co-authored-by: gskouson <1507929+gskouson@users.noreply.github.com>
viniciusferrao
changed the title
Obihoernchen
approved these changes
May 7, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the legacy ISC DHCP OMAPI/DDNS path so xCAT is no longer hardwired to
xcat_key,/usr/bin/omshell, and implicit HMAC-MD5 behavior.The default behavior stays compatible with existing installs. If an administrator does nothing, xCAT still uses
xcat_keywithhmac-md5. The new site attributes only matter when a site needs a different TSIG algorithm, a different OMAPI key name, or an alternateomshellbinary.Changes included here:
dhcpop.site.dhcpomapialgorithm,site.dhcpomapikeyname, andsite.dhcpomshellpath.omshellbehavior for the default MD5 case, since legacyomshelldoes not accept an explicitkey-algorithm hmac-md5.Validation:
Supersedes #7389.