fix: strip R:: prefix from netboot config#7573
Merged
Merged
Conversation
…tent When all addkcmdline options have R:: prefix (persistent options for the installed OS), the volatile check in xnba.pm and pxe.pm would fail because volatile was undefined. This left the original R::-prefixed string in the netboot config instead of stripping it. The fix ensures we always use the volatile portion after calling splitkcmdline, even if it's empty. Persistent (R::) options are handled separately by Template.pm via PERSKCMDLINE for the installed OS bootloader. Fixes xcat2#7442
Obihoernchen
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the behaviour when all
addkcmdlineoptions have R:: prefix (persistent options for the installed OS), the volatile check inxnba.pmandpxe.pmwould fail because volatile was undefined. This left the original R::-prefixed string in the netboot config instead of stripping it.Fixes #7442