Add actuator disc model #112
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semi-h
commented
Jul 11, 2025
Comment on lines
+171
to
+173
| call self%backend%vecadd(0._dp, Fx, 0._dp, Fx) | ||
| call self%backend%vecadd(0._dp, Fy, 0._dp, Fy) | ||
| call self%backend%vecadd(0._dp, Fz, 0._dp, Fz) |
Member
Author
There was a problem hiding this comment.
Just use call Fx%fill(0._dp) so on
Member
Author
There was a problem hiding this comment.
this is just to zeroise the field
semi-h
commented
Jul 11, 2025
Comment on lines
+579
to
+581
| !call self%backend%vecadd(self%windturb_adm%rho_air, Fx, 1._dp, du) | ||
| !call self%backend%vecadd(self%windturb_adm%rho_air, Fy, 1._dp, dv) | ||
| !call self%backend%vecadd(self%windturb_adm%rho_air, Fz, 1._dp, dw) |
Member
Author
There was a problem hiding this comment.
uncomment here to add the contribution of the wind turbines back into the RHS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the disc model using the existing backend functions, so compatible with all the backends.