Skip to content

Rebuild 8.3 drivers against v4.19.325-cip134 kernel. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casasnovas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rebuild 8.3 drivers against v4.19.325-cip134 kernel. #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/8.3/source/atlantic-module-alt
Open in desktop

@fallen fallen Sep 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why #if 0 ?

@casasnovas casasnovas Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the commit description:

c368c4defa94 ("net: create netdev->dev_addr assignment helpers") in
v4.19.291 made the definition of eth_hw_addr_set redundant and leads to
build errors like:

  In file included from /home/builder/rpmbuild/BUILD/atlantic-module-alt-2.5.12/aq_common.h:22:0,
		   from /home/builder/rpmbuild/BUILD/atlantic-module-alt-2.5.12/aq_nic.h:13,
		   from /home/builder/rpmbuild/BUILD/atlantic-module-alt-2.5.12/aq_nic.c:24:
  /home/builder/rpmbuild/BUILD/atlantic-module-alt-2.5.12/aq_compat.h:306:20: error: redefinition of 'eth_hw_addr_set'
   static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)
		      ^
  In file included from /home/builder/rpmbuild/BUILD/atlantic-module-alt-2.5.12/aq_nic.c:12:0:
  ./include/linux/etherdevice.h:301:20: note: previous definition of 'eth_hw_addr_set' was here
   static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)

Sadly we can't just add another linux version check to enforce the
definition in the header file when < 4.19.291 because the SUBLEVEL version
is always zero on our XS-derived kernels, and the SUBLEVEL has been moved
to an non-exported STABLE_SUBLEVEL variable only visible from the top-level
linux kernel Makefile.

Did you miss it or is there anything not clear?

@fallen fallen Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, sorry, I missed the commit, didn't see it.
Thanks it makes sense now.
It's really too bad we do the .0 thing with the sublevel value :(
Do you know why we/XS do this?

@casasnovas casasnovas Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is to have only one kernel installed and accompanying modules in /lib/modules/4.19.0+/ as opposed to having to install kernel modules in multiple directories, given lack of dkms support.

@fallen fallen Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, and since kABI is supposed to be stable, you don't need a set of module per kernel installed.
Just one set of modules is enough

Submodule atlantic-module-alt updated 1 files
+1 −1 aq_compat.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-e1000e-alt
Open in desktop
Submodule intel-e1000e-alt updated 1 files
+1 −1 src/kcompat.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-i40e
Open in desktop
Submodule intel-i40e updated 2 files
+1 −1 src/kcompat_gcc.h
+3 −1 src/virtchnl.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-i40e-alt
Open in desktop
Submodule intel-i40e-alt updated 1 files
+1 −1 src/kcompat_gcc.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-ice
Open in desktop
Submodule intel-ice updated 1 files
+1 −1 src/kcompat_gcc.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-ice-alt
Open in desktop
Submodule intel-ice-alt updated 1 files
+1 −1 src/kcompat_gcc.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-igb-alt
Open in desktop
Submodule intel-igb-alt updated 1 files
+1 −1 src/kcompat.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-ixgbe
Open in desktop
Submodule intel-ixgbe updated 1 files
+1 −1 src/kcompat_gcc.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/intel-ixgbe-alt
Open in desktop
Submodule intel-ixgbe-alt updated 1 files
+2 −1 src/kcompat.h
2 changes: 1 addition & 1 deletion drivers/8.3/source/qlogic-fastlinq-alt_8_42
Open in desktop
Submodule qlogic-fastlinq-alt_8_42 updated 2 files
+3 −3 qede-8.42.10.0/src/Makefile
+2 −1 qedi-8.42.10.0/Makefile
2 changes: 1 addition & 1 deletion drivers/8.3/source/qlogic-netxtreme2
Open in desktop
Submodule qlogic-netxtreme2 updated 3 files
+1 −2 bnx2-2.713.27/src/Makefile
+1 −1 bnx2x-1.715.8/src/Makefile
+2 −0 bnx2x-1.715.8/src/bnx2x_init.h
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/aqc111u-module
Open in desktop
Submodule aqc111u-module updated 1 files
+7 −1 SPECS/aqc111u-module.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/atlantic-module-alt
Open in desktop
Submodule atlantic-module-alt updated 2 files
+46 −0 SOURCES/0001-compat-support-kernel-4.19.291.patch
+10 −2 SPECS/atlantic-module-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/avago-megaraid-sas
Open in desktop
Submodule avago-megaraid-sas updated 1 files
+7 −1 SPECS/avago-megaraid-sas.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/avago-mpt3sas
Open in desktop
Submodule avago-mpt3sas updated 1 files
+7 −2 SPECS/avago-mpt3sas.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/broadcom-bnxt-en
Open in desktop
Submodule broadcom-bnxt-en updated 1 files
+7 −1 SPECS/broadcom-bnxt-en.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/broadcom-bnxt-en-alt
Open in desktop
Submodule broadcom-bnxt-en-alt updated 1 files
+7 −1 SPECS/broadcom-bnxt-en-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/chelsio-cxgb4
Open in desktop
Submodule chelsio-cxgb4 updated 1 files
+7 −1 SPECS/chelsio-cxgb4.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/cisco-enic
Open in desktop
Submodule cisco-enic updated 1 files
+7 −2 SPECS/cisco-enic.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/cisco-enic-alt
Open in desktop
Submodule cisco-enic-alt updated 1 files
+7 −1 SPECS/cisco-enic-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/cisco-fnic
Open in desktop
Submodule cisco-fnic updated 1 files
+7 −2 SPECS/cisco-fnic.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/cisco-fnic-alt
Open in desktop
Submodule cisco-fnic-alt updated 1 files
+7 −1 SPECS/cisco-fnic-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/coretemp-module-alt
Open in desktop
Submodule coretemp-module-alt updated 1 files
+8 −2 SPECS/coretemp-module-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/dell-rbu-module
Open in desktop
Submodule dell-rbu-module updated 1 files
+8 −2 SPECS/dell-rbu-module.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/emulex-lpfc
Open in desktop
Submodule emulex-lpfc updated 1 files
+7 −1 SPECS/emulex-lpfc.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/emulex-lpfc-alt
Open in desktop
Submodule emulex-lpfc-alt updated 1 files
+7 −1 SPECS/emulex-lpfc-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-e1000e
Open in desktop
Submodule intel-e1000e updated 1 files
+7 −1 SPECS/intel-e1000e.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-e1000e-alt
Open in desktop
Submodule intel-e1000e-alt updated 2 files
+45 −0 SOURCES/0001-Support-kernels-after-4.19.201.patch
+9 −1 SPECS/intel-e1000e-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-fm10k
Open in desktop
Submodule intel-fm10k updated 1 files
+7 −1 SPECS/intel-fm10k.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-i40e
Open in desktop
Submodule intel-i40e updated 2 files
+82 −0 SOURCES/0001-intel-i40e-compat-handle-newer-kernels-with-dd_key_i.patch
+9 −1 SPECS/intel-i40e.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-i40e-alt
Open in desktop
Submodule intel-i40e-alt updated 2 files
+60 −0 SOURCES/0001-intel-i40e-compat-handle-newer-kernels-with-dd_key_i.patch
+9 −1 SPECS/intel-i40e-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-ice
Open in desktop
Submodule intel-ice updated 2 files
+60 −0 SOURCES/0001-intel-ice-compat-handle-newer-kernels-with-dd_key_in.patch
+9 −1 SPECS/intel-ice.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-ice-alt
Open in desktop
Submodule intel-ice-alt updated 2 files
+60 −0 SOURCES/0001-intel-ice-compat-handle-newer-kernels-with-dd_key_in.patch
+8 −1 SPECS/intel-ice-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-igb
Open in desktop
Submodule intel-igb updated 1 files
+7 −1 SPECS/intel-igb.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-igb-alt
Open in desktop
Submodule intel-igb-alt updated 2 files
+42 −0 SOURCES/0001-compat-support-kernel-4.19.291-skb_frag_off.patch
+9 −1 SPECS/intel-igb-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-igc
Open in desktop
Submodule intel-igc updated 1 files
+7 −1 SPECS/intel-igc.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-ixgbe
Open in desktop
Submodule intel-ixgbe updated 2 files
+62 −0 SOURCES/0001-intel-ixgbe-compat-handle-newer-kernels-with-dd_key_.patch
+9 −1 SPECS/intel-ixgbe.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/intel-ixgbe-alt
Open in desktop
Submodule intel-ixgbe-alt updated 2 files
+51 −0 SOURCES/0001-intel-ixgbe-alt-compat-handle-newer-kernels-with-skb.patch
+9 −1 SPECS/intel-ixgbe-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/mellanox-mlnxen
Open in desktop
Submodule mellanox-mlnxen updated 1 files
+7 −1 SPECS/mellanox-mlnxen.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/mellanox-mlnxen-alt
Open in desktop
Submodule mellanox-mlnxen-alt updated 1 files
+7 −1 SPECS/mellanox-mlnxen-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/microsemi-aacraid
Open in desktop
Submodule microsemi-aacraid updated 1 files
+7 −1 SPECS/microsemi-aacraid.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/microsemi-smartpqi
Open in desktop
Submodule microsemi-smartpqi updated 1 files
+7 −1 SPECS/microsemi-smartpqi.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/microsemi-smartpqi-alt
Open in desktop
Submodule microsemi-smartpqi-alt updated 1 files
+7 −2 SPECS/microsemi-smartpqi-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/mlx4-modules-alt
Open in desktop
Submodule mlx4-modules-alt updated 1 files
+7 −1 SPECS/mlx4-modules-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/mpi3mr-module
Open in desktop
Submodule mpi3mr-module updated 1 files
+7 −1 SPECS/mpi3mr-module.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/qlogic-fastlinq
Open in desktop
Submodule qlogic-fastlinq updated 1 files
+7 −1 SPECS/qlogic-fastlinq.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/qlogic-fastlinq-alt
Open in desktop
Submodule qlogic-fastlinq-alt updated 1 files
+7 −1 SPECS/qlogic-fastlinq-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/qlogic-fastlinq-alt_8_42
Open in desktop
Submodule qlogic-fastlinq-alt_8_42 updated 2 files
+68 −0 SOURCES/0001-qede-compat-check-for-prandom_bytes-in-prandom.h-as-.patch
+9 −1 SPECS/qlogic-fastlinq-alt_8_42.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/qlogic-netxtreme2
Open in desktop
Submodule qlogic-netxtreme2 updated 3 files
+49 −0 SOURCES/0001-bnx2-compat-check-for-prandom_bytes-in-prandom.h-as-.patch
+30 −0 SOURCES/0001-bnx2x-use-kernel-definition-of-BITS_TO_BYTES-when-av.patch
+9 −2 SPECS/qlogic-netxtreme2.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/qlogic-netxtreme2-alt
Open in desktop
Submodule qlogic-netxtreme2-alt updated 1 files
+7 −1 SPECS/qlogic-netxtreme2-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/qlogic-qla2xxx
Open in desktop
Submodule qlogic-qla2xxx updated 1 files
+7 −1 SPECS/qlogic-qla2xxx.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/qlogic-qla2xxx-alt
Open in desktop
Submodule qlogic-qla2xxx-alt updated 1 files
+7 −1 SPECS/qlogic-qla2xxx-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/r8125-module
Open in desktop
Submodule r8125-module updated 1 files
+7 −1 SPECS/r8125-module.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/r8169-module-alt
Open in desktop
Submodule r8169-module-alt updated 1 files
+7 −1 SPECS/r8169-module-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/sfc-module-alt
Open in desktop
Submodule sfc-module-alt updated 1 files
+7 −1 SPECS/sfc-module-alt.spec
2 changes: 1 addition & 1 deletion drivers/8.3/srpm/tg3-module-alt
Open in desktop
Submodule tg3-module-alt updated 1 files
+7 −2 SPECS/tg3-module-alt.spec
Loading
Loading