Skip to content

Conversation

psafont
Copy link
Contributor

@psafont psafont commented Jul 16, 2025

Aside from adding metadata to pyproject.toml to be able to create a package and upload it to the github release, it also adds a default license (GPL), and tweaks the workflows.

I think the template should also provide some kind of testing, as well as adding it to a workflow, maybe for another PR

@glehmann
Copy link
Member

I can't see any test run here, apart from the DCO check. Am I missing something?

@psafont
Copy link
Contributor Author

psafont commented Jul 16, 2025

The new workflow only gets run when a new tag is pushed in the repo

@psafont psafont force-pushed the main branch 5 times, most recently from 4ed8c40 to c3c1c32 Compare July 16, 2025 15:01
@psafont
Copy link
Contributor Author

psafont commented Jul 16, 2025

@psafont psafont force-pushed the main branch 2 times, most recently from c620bd4 to 6bdbcd6 Compare July 17, 2025 08:49
@psafont
Copy link
Contributor Author

psafont commented Jul 17, 2025

I can't see any test run here, apart from the DCO check. Am I missing something?

Maybe I'm not authorized to run the workflows? they are running well on my fork: https://github.com/psafont/python-project-template/actions

psafont added 2 commits August 4, 2025 10:24
This allows any tool to download build dependencies and package the
code.

Include setuptools_scm to generate package version from git

Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
@psafont psafont marked this pull request as draft August 4, 2025 09:31
@psafont
Copy link
Contributor Author

psafont commented Aug 4, 2025

Drafted because it's not running the tests here, and the zizmore check is failing on my fork

@psafont psafont marked this pull request as ready for review August 4, 2025 09:52
@psafont psafont force-pushed the main branch 2 times, most recently from a121590 to 21f4041 Compare August 4, 2025 10:01
psafont added 2 commits August 4, 2025 11:05
An action to release the package to PyPI could be done, but needs a
prior setup in PyPI to allow the upload, see
https://docs.pypi.org/trusted-publishers/adding-a-publisher/

```
  publish-pypi:
    name: Publish Python release to PyPI
    runs-on: ubuntu-latest
    needs: release
    environment: pypi
    permissions:
      contents: read
      id-token: write
    steps:
      - name: Retrieve python distribution artifacts
        uses: actions/download-artifact@v4
        with:
          name: artifacts
          path: dist/

      - name: Publish to PyPI
        uses: pypa/gh-action-pypi-publish@release/v1
```

Signed-off-by: Pau Ruiz Safont <[email protected]>
uv was printing a warning stating that using the tilde in this way is
ammbiguous. The new version range is precise

Signed-off-by: Pau Ruiz Safont <[email protected]>
@psafont
Copy link
Contributor Author

psafont commented Aug 4, 2025

@psafont psafont merged commit be62914 into xcp-ng:master Aug 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants