Improve error messages when vdi_type is missing#103
Merged
Wescoeur merged 1 commit into3.2.12-8.3from Dec 8, 2025
Merged
Conversation
klmp200
force-pushed
the
improve-error-with-bad-mgt
branch
from
4f420ee to
d452e1d
Compare
Wescoeur
requested changes
Oct 10, 2025
klmp200
force-pushed
the
improve-error-with-bad-mgt
branch
from
d452e1d to
4d34bd3
Compare
Wescoeur
approved these changes
Oct 14, 2025
klmp200
force-pushed
the
improve-error-with-bad-mgt
branch
from
4d34bd3 to
0ab6925
Compare
Nambrok
requested changes
Oct 23, 2025
klmp200
force-pushed
the
improve-error-with-bad-mgt
branch
from
0ab6925 to
bde2e79
Compare
Nambrok
approved these changes
Oct 24, 2025
Member
|
Sounds good. However, I think we can try to open a PR on the upstream side to avoid maintaining too many divergences on our side. |
Wescoeur
force-pushed
the
3.2.12-8.3
branch
2 times, most recently
from
66c7c8e to
aaaab27
Compare
klmp200
force-pushed
the
improve-error-with-bad-mgt
branch
from
bde2e79 to
c755464
Compare
Author
|
Merged upstream here xapi-project#780 |
Member
|
Can you add the PR upstream changes here? If that's too complex we can deal without it. |
Explicit error message pointing to missing vdi_type on SRMetadata update Add a distinction for unpacking corrupted empty metadata headers for easier diagnostic Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
klmp200
force-pushed
the
improve-error-with-bad-mgt
branch
from
c755464 to
9369caf
Compare
Author
Of course, here it is :) I've had to change one test slightly because it relied on some method that only exists upstream but it's almost identical. |
Wescoeur
pushed a commit
that referenced
this pull request
Dec 9, 2025
Explicit error message pointing to missing vdi_type on SRMetadata update Add a distinction for unpacking corrupted empty metadata headers for easier diagnostic Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
Wescoeur
pushed a commit
that referenced
this pull request
Dec 9, 2025
Explicit error message pointing to missing vdi_type on SRMetadata update Add a distinction for unpacking corrupted empty metadata headers for easier diagnostic Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit error message pointing to missing vdi_type on SRMetadata update Add a distinction for unpacking corrupted empty metadata headers for easier diagnostic