Repository navigation
feat(linstorvolumemanager): raise when empty device path is detected - #104
Merged
Merged
Conversation
Member
Author
|
For the context of this commit, we have a ticket regarding a completely empty path causing an error during an unpause call: I'm trying to make sure that the problem is caused by the LINSTOR API and not something else in our driver. |
In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
force-pushed
the
ran-log-empty-dev-res-path
branch
from
October 23, 2025 22:08
b5c1e8e to
ee6425c
Compare
Millefeuille42
approved these changes
Oct 24, 2025
Wescoeur
added a commit
that referenced
this pull request
Dec 1, 2025
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Dec 1, 2025
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Dec 1, 2025
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Dec 9, 2025
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Dec 9, 2025
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Millefeuille42
pushed a commit
that referenced
this pull request
Dec 10, 2025
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Feb 2, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Feb 3, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Feb 3, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Feb 3, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
May 19, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
May 19, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Jun 25, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Jun 25, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Jun 25, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Jun 25, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Jun 25, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Nambrok
pushed a commit
that referenced
this pull request
Sep 23, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Sep 24, 2026
…104) In `_request_device_path`: Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
_request_device_path:Before this change, an exception was thrown when a resource was missing, but not when the returned path was empty. Now it's raised in both cases.