Skip to content

Comments

Add missing image-format attr on snap VDIs#113

Merged
Wescoeur merged 1 commit intodtt-3.2.12-8.3-qcow2-cowutilfrom
add_attr_image_format_on_snapshots_sm_config
Dec 16, 2025
Merged

Add missing image-format attr on snap VDIs#113
Wescoeur merged 1 commit intodtt-3.2.12-8.3-qcow2-cowutilfrom
add_attr_image_format_on_snapshots_sm_config

Conversation

@Lankou66
Copy link

@Lankou66 Lankou66 commented Nov 25, 2025

add image-format key in lvmsr and filesr snaphot sm-config dict

@Lankou66 Lankou66 requested a review from Nambrok November 25, 2025 09:01
@Lankou66 Lankou66 marked this pull request as ready for review November 25, 2025 09:02
@Lankou66 Lankou66 requested a review from Wescoeur November 25, 2025 09:42
@Wescoeur
Copy link
Member

Have you checked all the drivers?

@Wescoeur
Copy link
Member

Wescoeur commented Nov 25, 2025

I suggest this commit name:

Add missing `image-format` attr on snap VDIs`.

@Lankou66
Copy link
Author

@Wescoeur i'll double check but it seems ok to me for the other drivers

@Lankou66 Lankou66 force-pushed the add_attr_image_format_on_snapshots_sm_config branch from 4e9a748 to 866011f Compare November 25, 2025 14:04
@Wescoeur Wescoeur changed the title add image-format key from parent device in snaphot smconfig Add missing image-format attr on snap VDIs Nov 25, 2025
@Nambrok Nambrok force-pushed the dtt-3.2.12-8.3-qcow2-cowutil branch from 77f3f2f to 800c849 Compare December 15, 2025 09:08
@Lankou66 Lankou66 force-pushed the add_attr_image_format_on_snapshots_sm_config branch from 866011f to 1a63a7c Compare December 15, 2025 12:08
@Lankou66 Lankou66 force-pushed the add_attr_image_format_on_snapshots_sm_config branch from 1a63a7c to 78423f2 Compare December 16, 2025 08:43
@Lankou66 Lankou66 force-pushed the add_attr_image_format_on_snapshots_sm_config branch from 78423f2 to 3314614 Compare December 16, 2025 13:53
Signed-off-by: Goulven Riou <goulven.riou@vates.tech>
@Lankou66 Lankou66 force-pushed the add_attr_image_format_on_snapshots_sm_config branch from 3314614 to af7e919 Compare December 16, 2025 14:03
@Wescoeur Wescoeur merged commit 276e1e4 into dtt-3.2.12-8.3-qcow2-cowutil Dec 16, 2025
5 checks passed
@Wescoeur Wescoeur deleted the add_attr_image_format_on_snapshots_sm_config branch December 16, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants