feat(linstor): parallelize SR.scan/cleanup (vhd-util calls)#115
Merged
Wescoeur merged 1 commit into3.2.12-8.3from Feb 9, 2026
Merged
feat(linstor): parallelize SR.scan/cleanup (vhd-util calls)#115Wescoeur merged 1 commit into3.2.12-8.3from
Wescoeur merged 1 commit into3.2.12-8.3from
Conversation
Member
Wescoeur
commented
Nov 29, 2025
Wescoeur
commented
- Simplify scan logic removing XAPI calls.
- Create one XAPI session / LINSTOR connection in each worker thread.
Member
Author
|
This code is clearly not perfect or clean. We need to discuss it if we want to go with this approach. I tried to do this quickly because we're going to need it. I've probably left some errors, and we'll have to test it thoroughly. |
klmp200
requested changes
Dec 1, 2025
klmp200
reviewed
Dec 1, 2025
Wescoeur
force-pushed
the
3.2.12-8.3
branch
2 times, most recently
from
66c7c8e to
aaaab27
Compare
Wescoeur
force-pushed
the
ran-xostor-fast-scan
branch
from
7fa711a to
a1eaa0e
Compare
Wescoeur
force-pushed
the
ran-xostor-fast-scan
branch
from
a1eaa0e to
59d9578
Compare
Wescoeur
force-pushed
the
3.2.12-8.3
branch
3 times, most recently
from
9cbd470 to
81418fa
Compare
Wescoeur
force-pushed
the
ran-xostor-fast-scan
branch
5 times, most recently
from
64a22fc to
9ecaab9
Compare
klmp200
requested changes
Feb 5, 2026
klmp200
left a comment
klmp200
left a comment
There was a problem hiding this comment.
I don't see any logic issue, that should improve performance a lot :)
- Simplify scan logic removing XAPI calls. - Create one XAPI session / LINSTOR connection in each worker thread. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
force-pushed
the
ran-xostor-fast-scan
branch
from
9ecaab9 to
716954a
Compare
klmp200
approved these changes
Feb 5, 2026
Millefeuille42
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.