Skip to content

Fix a crash with cleanup operation while a host is offline.#123

Merged
Ythogtha merged 1 commit into3.2.12-8.3from
agf-fileSR_fix_with_offline_hosts
Feb 13, 2026
Merged

Fix a crash with cleanup operation while a host is offline.#123
Ythogtha merged 1 commit into3.2.12-8.3from
agf-fileSR_fix_with_offline_hosts

Conversation

@Ythogtha
Copy link

@Ythogtha Ythogtha commented Feb 4, 2026

When checking attached hosts, the exception to ignore for offline hosts is XenAPI.Failure.

@Ythogtha Ythogtha force-pushed the agf-fileSR_fix_with_offline_hosts branch from e44de20 to 6508546 Compare February 5, 2026 12:48
@Ythogtha Ythogtha force-pushed the agf-fileSR_fix_with_offline_hosts branch 2 times, most recently from 2cec5c3 to b85d924 Compare February 12, 2026 16:01
@Ythogtha Ythogtha marked this pull request as ready for review February 12, 2026 16:01
@Wescoeur Wescoeur requested review from Nambrok and Wescoeur February 12, 2026 16:46
@Wescoeur
Copy link
Member

Wescoeur commented Feb 12, 2026

Commit suggestion:

fix(cleanup): properly handle FileSR exception for slave check

A plugin is used by the `_checkSlave` helper. Therefore, `call_plugin` is executed instead of a command helper, which means that `CommandException` cannot be raised.

A plugin is used by the `_checkSlave` helper.
Therefore, `call_plugin` is executed instead of a command helper, which means that `CommandException` cannot be raised.

Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
@Ythogtha Ythogtha force-pushed the agf-fileSR_fix_with_offline_hosts branch from b85d924 to 3e18aee Compare February 13, 2026 08:49
@Ythogtha Ythogtha merged commit 93479fa into 3.2.12-8.3 Feb 13, 2026
5 checks passed
Wescoeur pushed a commit that referenced this pull request Feb 13, 2026
A plugin is used by the `_checkSlave` helper.
Therefore, `call_plugin` is executed instead of a command helper, which means that `CommandException` cannot be raised.

Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
@Wescoeur Wescoeur deleted the agf-fileSR_fix_with_offline_hosts branch February 13, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments