fix(blktap2): Retry tag removal on XAPI HTTP failure. - #149
Merged
Conversation
Ythogtha
force-pushed
the
agf-XAPI_retry_call_wrapper
branch
2 times, most recently
from
July 24, 2026 15:01
086146a to
9960a59
Compare
Decorator to retry a method when it fails with HTTPStatus.INTERNAL_SERVER_ERROR Should only be used for replayable XAPI operations. Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
DatBewar
approved these changes
Jul 24, 2026
AnthoineB
reviewed
Jul 24, 2026
AnthoineB
left a comment
AnthoineB
left a comment
Member
There was a problem hiding this comment.
The patch seems simple and clear.
As the Plane card speaks about a generic solution, can you create a second commit to convert one or two other functions with the same pattern?
Wescoeur
requested changes
Jul 28, 2026
Ythogtha
force-pushed
the
agf-XAPI_retry_call_wrapper
branch
from
July 30, 2026 10:13
3d6c66e to
ea529f3
Compare
This method gets data, therefore it can be retried. Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
Author
I've added a few commits, going through blktap2 to add retry where it is useful. |
Ythogtha
force-pushed
the
agf-XAPI_retry_call_wrapper
branch
from
July 30, 2026 10:45
c77c92c to
c2660f9
Compare
Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
…_coalesce_chain() Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
Avoids having to XAPI-retry the calls. There is no purpose in gathering unused data. Note: There might be an undocumented side-effect to this removal. Signed-off-by: Arnaud Garcia-Fernandez <arnaud.garcia-fernandez@vates.tech>
Wescoeur
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decorator to retry a method when it fails with HTTPStatus.INTERNAL_SERVER_ERROR
Should only be used for replayable XAPI operations.