Repository navigation
Conversation
Wescoeur
reviewed
Sep 16, 2026
| @override | ||
| def getExtendedL2(self, path: str) -> bool: | ||
| self._read_qcow2(path) | ||
| return bool(self.header["incompatible_features"] & QCowUtil.QCOW2_INCOMPATIBLE_FEATURE_EXTENDED_L2) |
Member
There was a problem hiding this comment.
@Nambrok I'm only noticing this now, but why use the name "QCowUtil" throughout the file instead of using self. or cls.? 😅 IMHO it simplifies maintenance in case of renaming.
Member
Author
There was a problem hiding this comment.
Agree. I follow the others constants. I will change this.
Wescoeur
requested changes
Sep 16, 2026
AnthoineB
force-pushed
the
abs-qcow2util-support-subclusters
branch
from
September 17, 2026 08:47
492d822 to
c5476ba
Compare
Nambrok
force-pushed
the
3.2.12-8.3-devel
branch
from
September 18, 2026 14:11
acc492e to
087fc03
Compare
AnthoineB
force-pushed
the
abs-qcow2util-support-subclusters
branch
from
September 18, 2026 14:20
c5476ba to
8fb96fb
Compare
Wescoeur
requested changes
Sep 21, 2026
Kuruyia
reviewed
Sep 21, 2026
AnthoineB
force-pushed
the
abs-qcow2util-support-subclusters
branch
4 times, most recently
from
September 21, 2026 15:16
cbe9a10 to
515c4ec
Compare
Kuruyia
reviewed
Sep 21, 2026
AnthoineB
force-pushed
the
abs-qcow2util-support-subclusters
branch
2 times, most recently
from
September 21, 2026 15:24
a34b980 to
d120ca3
Compare
Nambrok
force-pushed
the
3.2.12-8.3-devel
branch
from
September 23, 2026 15:22
3a2a643 to
643d0ba
Compare
Wescoeur
force-pushed
the
3.2.12-8.3-devel
branch
2 times, most recently
from
September 24, 2026 14:28
c302395 to
93648e6
Compare
Nambrok
force-pushed
the
3.2.12-8.3-devel
branch
from
September 25, 2026 08:39
93648e6 to
f60e4c5
Compare
AnthoineB
force-pushed
the
abs-qcow2util-support-subclusters
branch
2 times, most recently
from
October 6, 2026 10:00
3e37923 to
66cb747
Compare
Create Qcow2 with subclusters if the parent support it. calcOverheadEmpty defaults to extended_l2 because it needs more space. Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
AnthoineB
force-pushed
the
abs-qcow2util-support-subclusters
branch
from
October 6, 2026 10:04
66cb747 to
69c176f
Compare
Kuruyia
approved these changes
Oct 6, 2026
Comment on lines
+149
to
+150
| if incompatible_features & QCowUtil.IncompatibleFeatures.COMPRESSION_TYPE: | ||
| raise ValueError("QCOW2: Image compression is not supported") |
There was a problem hiding this comment.
Note for later: this incompatible feature is about non-default compression algorithms specifically; if we are to support compressed clusters in the future, but only with the default algorithm, then we mustn't mark this feature as supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Qcow2 VDI with subclusters if the parent supports it. Without this patch we copy the large cluster size without extended_l2 set.
calcOverheadEmpty defaults to extended_l2 because subclusters needs more space at equivalent cluster size.