Skip to content

doc(linstor): fix wrong comments on _call_local_method #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wescoeur merged 1 commit into from
Oct 7, 2026
Merged

doc(linstor): fix wrong comments on _call_local_method #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions drivers/linstorcowutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,13 +543,14 @@ def local_call():
return local_method(device_path, *args, **kwargs)
except util.CommandException as e:
if e.code in (errno.EROFS, errno.EMEDIUMTYPE):
raise ErofsLinstorCallException(e) # Break retry calls.
raise ErofsLinstorCallException(e)
if e.code == errno.ENODATA:
raise NoDataLinstorCallException(e)
if e.code == errno.ENOENT:
raise NoPathLinstorCallException(e)
raise e
# Retry only locally if it's not an EROFS exception.
raise e # Continue to retry calls.
# Retry only locally if it's not a LinstorCallException.
# ENODATA is retried on blktap2 directly, to handle transient DRBD errors.
return util.retry(local_call, 5, 2, exceptions=[util.CommandException])
except util.CommandException as e:
util.SMlog('failed to execute locally CowUtil (sys {})'.format(e.code))
Expand Down
Loading