Update image build instructions #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
requested changes
Oct 14, 2025
Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
force-pushed
the
gln/doc-image-build-uosq
branch
from
e49ab1a to
8c87cdd
Compare
ydirson
approved these changes
Oct 14, 2025
stormi
reviewed
Oct 14, 2025
Comment on lines
+81
to
+95
| ## Building the container image(s) | ||
|
|
||
| You need one container image per target version of XCP-ng. | ||
|
|
||
| Clone this repository (outside any container), then use `xcp-ng-dev-env-create` to | ||
| generate the images for the wanted releases of XCP-ng. | ||
| Clone this repository (outside any container), then use `./container/build.sh` to | ||
| generate the image. Adapt the version to the wanted release of XCP-ng. | ||
| Note that Docker and Podman store container images separately. | ||
|
|
||
| ``` | ||
| Usage: xcp-ng-dev-env-create {version_of_XCP_ng} | ||
| ... where {version_of_XCP_ng} is a 'x.y' version such as 8.0. | ||
| Usage: ./container/build.sh [--platform PF] <version> | ||
| ... where <version> is a 'x.y' version such as 8.0. |
There was a problem hiding this comment.
I think here we could remind first that you can download a pre-built image if all you want is to use it.
Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
force-pushed
the
gln/doc-image-build-uosq
branch
from
8c87cdd to
b85b759
Compare
|
@glehmann I haven't seen a re-review request, but seeing the diff I suppose there was an implicit one (caution with implicit re-review requests, they don't always work :)) |
stormi
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to update them when I removed
xcp-ng-dev-env-create.