Glossary review#467
Conversation
|
79be742 to
0f3765f
Compare
|
I think it's a good idea to restrict this PR on the glossary. I'll propose other changes next. |
ce1e363 to
b4da6b0
Compare
stormi
left a comment
There was a problem hiding this comment.
I think you lost the original commit message when you squashed. Always double check before asking for a review 🙏.
And a few more changes:
- Use semicolons
- Order entries alphabetically
- Fix typo
| * XCP - Xen Cloud Platform | ||
| * XCP-ng - XCP New Generation | ||
| * CoW: [Copy-on-write](https://en.wikipedia.org/wiki/Copy-on-write) | ||
| * Dom0: Abbreviation for "[domain 0](https://wiki.xenproject.org/wiki/Dom0)" |
There was a problem hiding this comment.
This should explain what domain 0. Not just with an external link, but with a few simple words. Like the previous version did rather well IMO.
There was a problem hiding this comment.
I have no problems with previous version, it’s just that was the only term explained, all others has only acronym expansion. That’s why, in a manner of page consistance, I removed the explanation and mention an external link
There was a problem hiding this comment.
I think it would be more useful to, on the contrary, have explanations inside the glossary rather than relying on external links that are not always appropriate from a pedagogical point of view. Links are a plus, but should not be mandatory to get something useful out of one's reading of a glossary.
| * XCP-ng - XCP New Generation | ||
| * CoW: [Copy-on-write](https://en.wikipedia.org/wiki/Copy-on-write) | ||
| * Dom0: Abbreviation for "[domain 0](https://wiki.xenproject.org/wiki/Dom0)" | ||
| * DomU: Abbreviation for "[unprivileged domain](https://wiki.xenproject.org/wiki/DomU)" (no access to the hardware) |
There was a problem hiding this comment.
That's the Xen name for what we and most users call VMs or guests. This should be stated.
There was a problem hiding this comment.
OK, that’s an important precision. I found this term when reading about dom0. I didn’t thought that it’s another name for a VM. I’ll add this precision
There was a problem hiding this comment.
That been said, DomU is only mentioned in docs/project/architecture.md page, so maybe it’s relevant to update it and change the term?
There was a problem hiding this comment.
domU is an important term in Xen's architecture. We use it a lot less in our docs, but I think it's still useful to mention it as a synonym to guest and virtual machine.
| * PIF: [Physical Interface](/project/architecture/#pifs) | ||
| * PV: [Para-Virtualization](https://wiki.xenproject.org/wiki/Paravirtualization_(PV)) | ||
| * QCOW: [_QEMU Copy On Write_](https://en.wikipedia.org/wiki/Qcow), a disk image file format ([specification](https://www.qemu.org/docs/master/interop/qcow2.html)) | ||
| * RPU: [Rolling Pool Update](/management/updates/#from-xen-orchestra) |
There was a problem hiding this comment.
I wouldn't add it here. RPU has two meanings. Rolling Pool Update and Rolling Pool Upgrade. The later involves a different process and a change in versions. I've check the docs, we already explain what RPU is in the sections of the doc that cover it.
| * PV: [Para-Virtualization](https://wiki.xenproject.org/wiki/Paravirtualization_(PV)) | ||
| * QCOW: [_QEMU Copy On Write_](https://en.wikipedia.org/wiki/Qcow), a disk image file format ([specification](https://www.qemu.org/docs/master/interop/qcow2.html)) | ||
| * RPU: [Rolling Pool Update](/management/updates/#from-xen-orchestra) | ||
| * SMAPI: [Storage Manager API](https://github.com/xapi-project/xapi-storage) |
There was a problem hiding this comment.
The link is wrong. And we should make a difference between SMAPIv1 and SMAPIv3.
There was a problem hiding this comment.
The link mentioned relate explicitly to SMAPIv3
Xapi storage interface ("SMAPIv3")
If you can provide a suggestion, I’ll appreciated it (-;
There was a problem hiding this comment.
Exactly. This link is about SMAPIv3. It doesn't explain what SMAPI is, and SMAPI exists in several different versions (v1 and v3).
For suggestions, I let you see with your team (storage), as this is their area.
I'm the final reviewer for this doc, so I need the PR to be refined with whoever is necessary before I can do the final pass on it.
| * SMAPI: [Storage Manager API](https://github.com/xapi-project/xapi-storage) | ||
| * SR: [Storage Repository](/storage/) | ||
| * VBD: [Virtual Block Device](https://docs.kernel.org/block/ublk.html) | ||
| * VDI: Oracle's _VirtualBox Disk Image_ format |
There was a problem hiding this comment.
This seems wrong to me. It's not a format, it's a concept and a XAPI object.
There was a problem hiding this comment.
OK, I remove it. I didn’t find convincing context or explanation for this one (that’s why I didn’t provide link)
| * VG: [LVM's Volume Group](https://www.man7.org/linux/man-pages/man8/lvm.8.html#DESCRIPTION) | ||
| * VHD: [_Virtual Hard Disk_ file format](https://en.wikipedia.org/wiki/VHD_(file_format)) ([specification](https://www.microsoft.com/en-us/download/details.aspx?id=23850)) | ||
| * VMDK: [_Virtual Machine Disk_ file format](https://en.wikipedia.org/wiki/VMDK) ([specification](https://github.com/libyal/libvmdk/blob/main/documentation/VMWare%20Virtual%20Disk%20Format%20(VMDK).asciidoc)) | ||
| * VM: [Virtual Machine](https://en.wikipedia.org/wiki/Virtual_machine) |
| * VHD: [_Virtual Hard Disk_ file format](https://en.wikipedia.org/wiki/VHD_(file_format)) ([specification](https://www.microsoft.com/en-us/download/details.aspx?id=23850)) | ||
| * VMDK: [_Virtual Machine Disk_ file format](https://en.wikipedia.org/wiki/VMDK) ([specification](https://github.com/libyal/libvmdk/blob/main/documentation/VMWare%20Virtual%20Disk%20Format%20(VMDK).asciidoc)) | ||
| * VM: [Virtual Machine](https://en.wikipedia.org/wiki/Virtual_machine) | ||
| * XAPI: [Xen Project Management API](/management/manage-at-scale/xo-api/) |
There was a problem hiding this comment.
It's XCP-ng's control plane.
The link is wrong.
|
Thanks for reviewing @stormi , I’ll proceed |
| * XCP - Xen Cloud Platform | ||
| * XCP-ng - XCP New Generation | ||
| * CoW: [Copy-on-write](https://en.wikipedia.org/wiki/Copy-on-write) | ||
| * Dom0: Abbreviation for "[domain 0](https://wiki.xenproject.org/wiki/Dom0)" |
There was a problem hiding this comment.
I have no problems with previous version, it’s just that was the only term explained, all others has only acronym expansion. That’s why, in a manner of page consistance, I removed the explanation and mention an external link
| * XCP-ng - XCP New Generation | ||
| * CoW: [Copy-on-write](https://en.wikipedia.org/wiki/Copy-on-write) | ||
| * Dom0: Abbreviation for "[domain 0](https://wiki.xenproject.org/wiki/Dom0)" | ||
| * DomU: Abbreviation for "[unprivileged domain](https://wiki.xenproject.org/wiki/DomU)" (no access to the hardware) |
There was a problem hiding this comment.
OK, that’s an important precision. I found this term when reading about dom0. I didn’t thought that it’s another name for a VM. I’ll add this precision
| * XCP-ng - XCP New Generation | ||
| * CoW: [Copy-on-write](https://en.wikipedia.org/wiki/Copy-on-write) | ||
| * Dom0: Abbreviation for "[domain 0](https://wiki.xenproject.org/wiki/Dom0)" | ||
| * DomU: Abbreviation for "[unprivileged domain](https://wiki.xenproject.org/wiki/DomU)" (no access to the hardware) |
There was a problem hiding this comment.
That been said, DomU is only mentioned in docs/project/architecture.md page, so maybe it’s relevant to update it and change the term?
| * PIF: [Physical Interface](/project/architecture/#pifs) | ||
| * PV: [Para-Virtualization](https://wiki.xenproject.org/wiki/Paravirtualization_(PV)) | ||
| * QCOW: [_QEMU Copy On Write_](https://en.wikipedia.org/wiki/Qcow), a disk image file format ([specification](https://www.qemu.org/docs/master/interop/qcow2.html)) | ||
| * RPU: [Rolling Pool Update](/management/updates/#from-xen-orchestra) |
| * PV: [Para-Virtualization](https://wiki.xenproject.org/wiki/Paravirtualization_(PV)) | ||
| * QCOW: [_QEMU Copy On Write_](https://en.wikipedia.org/wiki/Qcow), a disk image file format ([specification](https://www.qemu.org/docs/master/interop/qcow2.html)) | ||
| * RPU: [Rolling Pool Update](/management/updates/#from-xen-orchestra) | ||
| * SMAPI: [Storage Manager API](https://github.com/xapi-project/xapi-storage) |
There was a problem hiding this comment.
The link mentioned relate explicitly to SMAPIv3
Xapi storage interface ("SMAPIv3")
If you can provide a suggestion, I’ll appreciated it (-;
| * SMAPI: [Storage Manager API](https://github.com/xapi-project/xapi-storage) | ||
| * SR: [Storage Repository](/storage/) | ||
| * VBD: [Virtual Block Device](https://docs.kernel.org/block/ublk.html) | ||
| * VDI: Oracle's _VirtualBox Disk Image_ format |
There was a problem hiding this comment.
OK, I remove it. I didn’t find convincing context or explanation for this one (that’s why I didn’t provide link)
| * VHD: [_Virtual Hard Disk_ file format](https://en.wikipedia.org/wiki/VHD_(file_format)) ([specification](https://www.microsoft.com/en-us/download/details.aspx?id=23850)) | ||
| * VMDK: [_Virtual Machine Disk_ file format](https://en.wikipedia.org/wiki/VMDK) ([specification](https://github.com/libyal/libvmdk/blob/main/documentation/VMWare%20Virtual%20Disk%20Format%20(VMDK).asciidoc)) | ||
| * VM: [Virtual Machine](https://en.wikipedia.org/wiki/Virtual_machine) | ||
| * XAPI: [Xen Project Management API](/management/manage-at-scale/xo-api/) |
| * XCP-ng - XCP New Generation | ||
| * CoW: [Copy-on-write](https://en.wikipedia.org/wiki/Copy-on-write) | ||
| * Dom0: Abbreviation for "[domain 0](https://wiki.xenproject.org/wiki/Dom0)" | ||
| * DomU: Abbreviation for "[unprivileged domain](https://wiki.xenproject.org/wiki/DomU)", this is a lesser used term for <abbr title="Virtual Machine">VM</abbr> |
There was a problem hiding this comment.
That's not exactly what I said. WE use it less. Talk to xen developers, maybe they'll use it more, or use guest more.
There was a problem hiding this comment.
Not sure to understand exactly the point, can you make a suggestion?
There was a problem hiding this comment.
* DomU: In Xen terminology, a DomU (user domain) is what XCP-ng users would typically call a guest VM: a regular virtual machine running under the control of Dom0.
And a few more changes: - Use semicolons - Order entries alphabetically - Fix typo Signed-off-by: Frédéric Zind <frederic.zind@vates.tech>
This proposition aim to give a better solution to those: - xcp-ng#467 - xcp-ng#476 This is a first try: - a better integration on sidebar could be done - the sidebar is missing in the glossary page - the default glossary CSS is a bit wide on vertical range - and probably a lot of other things See plugin homepage: Signed-off-by: Frédéric Zind <frederic.zind@vates.tech>
) This proposition aim to give a better solution to those: - xcp-ng#467 - xcp-ng#476 See plugin homepage: https://github.com/mcclowes/docusaurus-plugin-glossary A term is kept only if it appears in the docs corpus (case-insensitive, whole-word, plural-aware). The native plugin behavior has been changed. Swizzle the plugin's GlossaryTerm theme component so the hover tooltip shows the term's full-name expansion (the abbreviation field, already present in glossary.json) before the definition, e.g. "VM - Virtual Machine - A guest operating system running on the hypervisor.". The upstream component renders term + definition only. The expansion is read from the abbreviation prop with a fallback to the plugin's global term data, and placeholder/empty expansions are skipped. See upstream PR: mcclowes/docusaurus-plugin-glossary#89 --- Signed-off-by: Frédéric Zind <frederic.zind@vates.tech> Co-authored-by: Bruno Verachten <bruno.verachten@vates.tech>
Terms has been curated and relates to the docs corpus (case-insensitive, whole-word, plural-aware). This proposition aim to give a better solution to those: - xcp-ng#467 - xcp-ng#476 Docusaurus «Glossary» plugin addition: Homepage: https://github.com/mcclowes/docusaurus-plugin-glossary The native plugin behavior has been changed. Swizzle the plugin's GlossaryTerm theme component so the hover tooltip shows the term's full-name expansion (the abbreviation field, already present in glossary.json) before the definition, e.g. "VM - Virtual Machine - A guest operating system running on the hypervisor.". The upstream component renders term + definition only. The expansion is read from the abbreviation prop with a fallback to the plugin's global term data, and placeholder/empty expansions are skipped. See: - upstream PR: mcclowes/docusaurus-plugin-glossary#89 - related issue: mcclowes/docusaurus-plugin-glossary#90 --- Co-authored-by: Bruno Verachten <bruno.verachten@vates.tech> Signed-off-by: Frédéric Zind <frederic.zind@vates.tech>
Uh oh!
There was an error while loading. Please reload this page.