Rebase on xenserver-release-8.4.0-18.xs8.src.rpm #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Thu Mar 13 2025 Gerald Elder-Vass <[email protected]> - 8.4.0-18 - CA-407370: Separate rsyslog configs for xenserver and customer (yes, the tarball version doesn't match the changelog entry, but both the tarball version and the SRPM release number are right) Signed-off-by: Samuel Verschelde <[email protected]>
stormi
force-pushed
the
8.3-rebase-XS-20250922
branch
from
46a0c24 to
f34cd5a
Compare
|
I suggest to have the main discussion on xcp-ng-rpms/xcp-ng-release#33 where the full change can be seen at once. |
* Mention XCP-ng in addition to XenServer. I didn't completely replace XenServer with XCP-ng. After all, the file is still named xenserver.conf, so that would be awkward. * Do NOT invite users to edit /etc/rsyslog.d/remote.conf, which is managed by XAPI. * Redirect any custom modifications to /etc/rsyslog.d/99-custom.conf, after validation by technical support. Signed-off-by: Samuel Verschelde <[email protected]>
stormi
force-pushed
the
8.3-rebase-XS-20250922
branch
from
f34cd5a to
25cc608
Compare
|
Now ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a good change, being clear about what belongs to default configuration you shouldn't touch and what belongs to user configuration.
We need to be careful about potential effects of not removing default rules anymore, but I haven't checked the changes in the SRPM itself.