lint python code with ruff #299
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same as xcp repository. Some checks are excluded in the tests directory, because pytest imposes to use some imports as functions arguments, and the linter doesn't know about that. Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
force-pushed
the
gln/ci-ruff-fixes-wqyp
branch
from
4822ecc to
08f9b93
Compare
|
no hurry on this review, it's there to trigger a discussion :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've used the same rules as in the xcp repository, but we probably want to remove some of them or add some more.
Look at the commit that fixes errors to get an idea of what you may or may not like.
All the available rules are documented at https://docs.astral.sh/ruff/rules/