Test disk integrity after migration #358
Open
+97
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glehmann
force-pushed
the
gln/migration-integrity
branch
from
39d33c4 to
08eb3f9
Compare
glehmann
force-pushed
the
gln/migration-integrity
branch
2 times, most recently
from
804519b to
4bbc22f
Compare
Signed-off-by: Gaëtan Lehmann <[email protected]>
stormi
reviewed
Oct 14, 2025
tests/storage/storage.py
Outdated
| logging.info("Generate /dev/xvdb content") | ||
| vm.ssh("randstream generate -v /dev/xvdb") | ||
| logging.info("Validate /dev/xvdb") | ||
| vm.ssh("randstream validate -v --expected-checksum 65280014 /dev/xvdb") |
There was a problem hiding this comment.
65280014: what is this number, and should it be a constant?
There was a problem hiding this comment.
That's the expected checksum—I hoped the --expected-checksum option would make it clear :)
We could use a different seed at each run to generate the content of the vdi. The checksum would change with it.
That would complicate the test though, and I'm not sure it would help to catch more problems.
There was a problem hiding this comment.
So it looks like it should at least be a constant.
glehmann
force-pushed
the
gln/migration-integrity
branch
from
4bbc22f to
f62c195
Compare
glehmann
force-pushed
the
gln/coalesce
branch
from
b50bda8 to
8be87e6
Compare
glehmann
force-pushed
the
gln/migration-integrity
branch
from
f62c195 to
a14dae3
Compare
The vdi uuid changes during migration, so we use its name to identify it Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
force-pushed
the
gln/migration-integrity
branch
from
a14dae3 to
bc22e1c
Compare
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
force-pushed
the
gln/migration-integrity
branch
from
bc22e1c to
6c7d966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #356