Conversation
semarie
force-pushed
the
srt/bond
branch
2 times, most recently
from
9419fb6 to
f8dd162
Compare
semarie
force-pushed
the
srt/bond
branch
3 times, most recently
from
2595a52 to
3042557
Compare
glehmann
reviewed
Jan 29, 2026
semarie
force-pushed
the
srt/bond
branch
3 times, most recently
from
179748f to
ff3d39d
Compare
semarie
force-pushed
the
srt/bond
branch
2 times, most recently
from
8e3aee2 to
60833c5
Compare
glehmann
reviewed
Feb 18, 2026
Member
glehmann
left a comment
glehmann
left a comment
There was a problem hiding this comment.
A few minor comments.
I let someone more knowledgeable in network comment on what the test is actually doing :)
glehmann
approved these changes
Feb 18, 2026
Member
glehmann
left a comment
glehmann
left a comment
There was a problem hiding this comment.
(forgot to click on approve when submitting my review)
- add some tests for Bond - add new abstractions (Network and Bond) with fixtures Signed-off-by: Sebastien Marie <semarie@kapouay.eu.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkandBond) with fixtures